#45142 closed submission (fixed)
pure-stldict @0.8: new port
| Reported by: | agraef (Albert Graef) | Owned by: | ryandesign (Ryan Carsten Schmidt) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.3.1 |
| Keywords: | Cc: | ryandesign (Ryan Carsten Schmidt) | |
| Port: | pure-stldict |
Description
This Pure module is currently missing in MacPorts. It is needed as a dependency for pd-faust.
Attachments (1)
Change History (8)
Changed 10 years ago by agraef (Albert Graef)
comment:1 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)
| Owner: | changed from macports-tickets@… to ryandesign@… |
|---|---|
| Status: | new → assigned |
Thanks, I've been meaning to get this port added.
I disagree with these lines you've added:
# MacPorts wants to override these, but we really need them as they are. build.post_args CXXFLAGS="-g -O2 -std=c++0x -Wall"
The reason why the pure portgroup sets CXXFLAGS is to build with the right -arch flags. Overriding this would normally mean -arch flags would no longer be used. However in this case I see they are still used, because the build also uses the LDFLAGS variable which still contains them.
But let's step back and look at the real reason why you added this line. Looks like the pure-stldict Makefile sets CXXFLAGS, and the portgroup is overriding it. Generally, there needs to be a way to build a piece of software with additional CXXFLAGS (and other flags). Up until now, my understanding was that they correct way to do this with pure modules was to just supply CXXFLAGS=... as an argument to the make command. If that actually overrides the Makefile's CXXFLAGS, what do you suggest instead?
Also, I see that the Makefile has a hardcoded reference to g++ which needs to be changed to $(CXX).
comment:2 Changed 10 years ago by agraef (Albert Graef)
Yes, the Makefile sets CXXFLAGS, that's not really good practice but it's just the way it is right now. I can fix that (along with the g++ -> $(CXX)) in a future release, but what to do with the current version? The quickest way to make the port work was to just set the build.post_args (rather than patching the Makefile), do you have another suggestion?
comment:3 follow-up: 6 Changed 10 years ago by agraef (Albert Graef)
BTW, pure-stllib (ticket #45143) most likely has the same issues.
comment:4 follow-up: 7 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)
For now we could have the portfile append to configure.cxxflags, since the portgroup includes that variable.
comment:5 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
comment:6 Changed 10 years ago by agraef (Albert Graef)
comment:7 Changed 10 years ago by agraef (Albert Graef)
Replying to ryandesign@…:
For now we could have the portfile append to
configure.cxxflags, since the portgroup includes that variable.
Ok, thanks. I've fixed the Makefile in the Pure repo already, so this will become unnecessary in the next release.
pure-stldict Portfile