chromaprint: fails to install libchromaprint.pc

[dbevans (David B. Evans)]

When building on Apple platforms, port chromaprint intentionally fails to install libchromaprint.pc. See CMakeLists.txt:

if(NOT APPLE AND NOT BUILD_FRAMEWORK)
        configure_file(${CMAKE_CURRENT_SOURCE_DIR}/libchromaprint.pc.cmake ${CMAKE_CURRENT_BINARY_DIR}/libchromaprint.pc)
        install(FILES ${CMAKE_CURRENT_BINARY_DIR}/libchromaprint.pc DESTINATION ${LIB_INSTALL_DIR}/pkgconfig)
endif()

This is inappropriate for MacPorts and causes some other ports (e.g. gstreamer1-gst-plugins-bad) to fail to detect libchromaprint during the configure phase even if it is installed.

[cooljeanius (Eric Gallager)]

Sounds like an upstream issue, although I suppose it does make sense to just patch it in the meantime while waiting on upstream...

[cooljeanius (Eric Gallager)]

Cc Me!

[dbevans (David B. Evans)]

The upstream assumption is that if it an Apple (native) platform or a framework is being built then the pkg-config file is not needed because it is a Linux-ism and not required for an Apple native environment or a framework. An equivalent logical expression is NOT (APPLE OR BUILD_FRAMEWORK).

However, in MacPorts we are often using Linux-style builds hence the need for the pkg-config file when the non-framework library is being installed. So I think using NOT (APPLE AND BUILD_FRAMEWORK) or just NOT BUILD_FRAMEWORK would be more appropriate for MacPorts.

A reasonable resolution IMO would be to apply a patch now, since this breaks pkg-config based configurations and open an issue upstream but I'm content to leave it to the maintainer's judgement.

[kurthindenburg (Kurt Hindenburg)]

I agree - thanks - fixed in r125843 and r125844

Issue opened ​https://bitbucket.org/acoustid/chromaprint/issue/13/mac-osx-install-libchromaprintpc