#45202 closed defect (fixed)
gtk3 quartz 3.14.0 fails to build on 10.6.8: 'NSFullScreenWindowMask' undeclared
| Reported by: | bugztrac@… | Owned by: | dbevans (David B. Evans) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.3.1 |
| Keywords: | Cc: | neverpanic (Clemens Lang), cooljeanius (Eric Gallager) | |
| Port: | gtk3 |
Description
gtk3 quartz fails to build on 10.6.8. See attached log file.
Attachments (1)
Change History (10)
Changed 10 years ago by bugztrac@…
| Attachment: | gtk3_build_log.txt added |
|---|
comment:1 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)
| Cc: | devans@… added |
|---|---|
| Owner: | changed from macports-tickets@… to cal@… |
comment:2 Changed 10 years ago by dbevans (David B. Evans)
| Cc: | cal@… added; devans@… removed |
|---|---|
| Owner: | changed from cal@… to devans@… |
| Status: | new → assigned |
Yes, indeed, the NSFullScreenWindowMask constant was not introduced until 10.7.
This is due to upstream commit https://git.gnome.org/browse/gtk+/commit/?id=ec17a649aed65fb0a27d6cf10ab097a5f310dfc6 which purports to add native full screen window support for 10.7+. Most of the code added is guarded by the AVAILABLE_MAC_OS_X_VERSION_10_7_AND_LATER availability macro but the code that adds the setStyleMask method to GdkQuartzNSWindow is not so protected, hence the failure.
As an immediate MacPorts fix we can back this commit out for 10.6 and earlier and I'll file a ticket upstream so a proper fix can be addressed.
Thanks for spotting this.
comment:3 Changed 10 years ago by dbevans (David B. Evans)
Patch committed in r125907 which backs out the offending upstream commit for 10.6 and earlier. I don't have a 10.6 test machine available so please update your ports, clean, rebuild and report back with your findings. Thanks.
comment:4 Changed 10 years ago by dbevans (David B. Evans)
Upstream bug report is https://bugzilla.gnome.org/show_bug.cgi?id=737561
comment:5 Changed 10 years ago by bugztrac@…
As requested, updated ports, cleaned gtk3 and rebuilt. Build succeeded. Thanks!
comment:6 Changed 10 years ago by dbevans (David B. Evans)
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
comment:8 Changed 10 years ago by dbevans (David B. Evans)
As of gtk3 version 3.14.5, committed in r128154, this issue is purported to have been fixed upstream (see bug report cited above). I've dropped the previous patch and would appreciate it if someone running 10.6 would test the +quartz build for this version and report back.
Thanks.
build log