Opened 10 years ago
Closed 10 years ago
#45348 closed enhancement (fixed)
gpredict perl bump and livecheck
| Reported by: | Schamschula (Marius Schamschula) | Owned by: | zapman@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | haspatch | Cc: | kurthindenburg (Kurt Hindenburg) |
| Port: | gpredict |
Description
I've updated gpredict to update the p5.12-xml-parser dependency to p5.16-xml-parser (#44405).
For gpredict default sourceforge livecheck is broken. Added a functioning livecheck.
Attachments (3)
Change History (12)
Changed 10 years ago by Schamschula (Marius Schamschula)
| Attachment: | Portfile-gpredict.diff added |
|---|
comment:1 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)
comment:2 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)
This particular port doesn't have an m4 directory so I'm not sure if copying intltool.m4 is needed or not.
comment:3 Changed 10 years ago by mf2k (Frank Schima)
| Cc: | zapman@… removed |
|---|---|
| Owner: | changed from macports-tickets@… to zapman@… |
| Type: | defect → enhancement |
| Version: | 2.3.1 |
comment:5 Changed 10 years ago by kurthindenburg (Kurt Hindenburg)
avoid redirects + fix livecheck r127878
comment:6 follow-up: 7 Changed 10 years ago by kurthindenburg (Kurt Hindenburg)
I briefly tried working w/ the above code and couldn't get anything to really work - should the xml-parser be updated to p5.16?
comment:7 Changed 10 years ago by dbevans (David B. Evans)
Replying to khindenburg@…:
I briefly tried working w/ the above code and couldn't get anything to really work - should the xml-parser be updated to p5.16?
The xml-parser dependency should be removed. It is only used by intltool and the dependency is correctly handled in that module.
Once that's done, autoreconf needs to be used to cause configure to be regenerated using our patched version of intltool.m4. This will allow the port to build regardless of which variant of perl5 is installed. Without this if anything other than perl5 +perl5_16 (the default) is used the build will fail in configure.
Attached is my current working patch that works for me. If it works for you feel free to commit it (maintainer timeout) and update #44405.
Changed 10 years ago by dbevans (David B. Evans)
| Attachment: | patch-gpredict-Portfile.diff added |
|---|
Patch to fix intltool perl issues
Changed 10 years ago by dbevans (David B. Evans)
| Attachment: | patch-gpredict-Portfile.2.diff added |
|---|
Also increment revision to remove any possible references to perl5.12.
comment:8 Changed 10 years ago by dbevans (David B. Evans)
Also should increment revision to make sure there are no references to perl5.12 remaining. See updated patch.
comment:9 Changed 10 years ago by dbevans (David B. Evans)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Fixed in r129733.
I doubt this port actually needs XML::Parser; it's probably just there because of intltool, which can be avoided by running autoreconf, as in:
# update m4/intltool.m4 and autoreconf pre-configure { copy -force ${prefix}/share/aclocal/intltool.m4 ${worksrcpath}/m4 } use_autoreconf yes autoreconf.args -fvi(this code is used in other ports already)