Opened 10 years ago

Closed 10 years ago

#45636 closed defect (fixed)

webkit-gtk fails to build on OS X 10.10 Yosemite

Reported by: gthb (Gunnlaugur Thor Briem) Owned by: jeremyhu (Jeremy Huddleston Sequoia)
Priority: Normal Milestone:
Component: ports Version: 2.3.2
Keywords: yosemite haspatch Cc:
Port: webkit-gtk

Description

Same problem as manifested on Mavericks and was fixed in #41663:

:info:build ./Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContext.h:79:21: error: no member named 'RedirectedXCompositeWindow' in namespace 'WebCore'
:info:build     OwnPtr<WebCore::RedirectedXCompositeWindow> m_redirectedWindow;
:info:build            ~~~~~~~~~^

... now reappears on Yosemite, simply because the fix in #41663 was targeted at platform darwin 13 (OS X 10.9 Mavericks). So the attached patch extends the fix to platform darwin 14 (OS X 10.10 Yosemite).

Attachments (1)

ticket-45636-fix-build-on-yosemite.diff (537 bytes) - added by gthb (Gunnlaugur Thor Briem) 10 years ago.
Portfile patch for same workaround as on Mavericks

Download all attachments as: .zip

Change History (3)

Changed 10 years ago by gthb (Gunnlaugur Thor Briem)

Portfile patch for same workaround as on Mavericks

comment:1 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: jeremyhu@… removed
Keywords: haspatch added
Owner: changed from macports-tickets@… to jeremyhu@…

Let's not repeat blocks. Instead modify the existing block to target darwin 13 or later instead of just 13.

comment:2 Changed 10 years ago by jeremyhu (Jeremy Huddleston Sequoia)

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.