cryptlib @3.4.2 fails to build on 10.10 with XCode 6.1

[JeNeSuisPasDave (Dave Hein)]

Getting errors like this:

:info:build bn/bn_asm.c:734:2: error: integer constant is larger than the largest unsigned integer type
:info:build         sqr_add_c2(a,1,0,c2,c3,c1);
:info:build         ^

And lots of warnings like this:

info:build bn/bn_asm.cbn/bn_asm.c::8888::33::  warning: warning: shift count >= width of type [-Wshift-count-overflow]
:info:build                 mul_add(rp[0],ap[0],w,c1);
:info:build                 ^~~~~~~~~~~~~~~~~~~~~~~~~
:info:build ./bn/bn_lcl.hshift count >= width of type [-Wshift-count-overflow]
:info:build                 mul_add(rp[0],ap[0],w,c1);
:info:build                 ^~~~~~~~~~~~~~~~~~~~~~~~~
:info:build ./bn/bn_lcl.h:315:7: note: expanded from macro 'mul_add'
:info:build         (c)= Hw(t); \
:info:build              ^~~~~
:info:build ./bn/bn_lcl.h:296:34: note: expanded from macro 'Hw'
:info:build #define Hw(t)    (((BN_ULONG)((t)>>BN_BITS2))&BN_MASK2)
:info:build                                  ^ ~~~~~~~~

Full log is attached.

[JeNeSuisPasDave (Dave Hein)]

build log

[JeNeSuisPasDave (Dave Hein)]

Drat. port in ticket metadata should be 'cryptlib'. Weird that I can't fix that after submission. :-(

[JeNeSuisPasDave (Dave Hein)]

Cc Me!

[ryandesign (Ryan Carsten Schmidt)]

The latest beta, 3.4.3 beta, still has this problem. I ​reported this problem to the cryptlib mailing list.

[ryandesign (Ryan Carsten Schmidt)]

I have finally realized that this problem goes away if I remove a patch we have been using:

browser:trunk/dports/devel/cryptlib/files/patch-crypt-osconfig.h.diff@114713​

This patch has been there for 6 years, since r58077 ("update to 3.3.3 and fix a bunch of stuff (#21536)"). It adds these lines on OS X:

  #if defined( __LP64__ )
	#undef SIXTY_FOUR_BIT
	#define SIXTY_FOUR_BIT_LONG
  #endif

This seems reasonable, since there is an earlier part of the file that does the same thing on 64-bit *BSD and Linux systems, but apparently it causes a problem now.

[jmroot (Joshua Root)]

I would certainly not assume that that patch is correct for versions other than 3.3.3.

[jmroot (Joshua Root)]

The compiler is right though, bn/bn.h says #define BN_MASK (0xffffffffffffffffffffffffffffffffLL) which is a 128-bit constant.

[jmroot (Joshua Root)]

128-bit numbers are really hard to work with, especially when avoiding nonstandard extensions. See what printf says when you try to give it one, for example. I confirmed the construct in the attached patch compares as greater than 0xffffffffffffffff at least.

[ryandesign (Ryan Carsten Schmidt)]

Has duplicate #48162. I'm waiting for the developers of cryptlib to release version 3.4.3 which should fix this.

[jmroot (Joshua Root)]

possible workaround

[ryandesign (Ryan Carsten Schmidt)]

Resolved by updating to 3.4.3 in r153798.