uhd undefined symbols for architecture x86_64

[mail@…]

I'm having trouble upgrading uhd on OSX 10.6.8 Im getting:

:info:build Undefined symbols for architecture x86_64:
:info:build   "uhd::niusrprio::niriok_proxy_impl_v1::NIRIO_RESOURCE::INPUT_FIFO", referenced from:
:info:build       uhd::niusrprio::niriok_proxy_impl_v1::add_fifo_resource(uhd::niusrprio::nirio_fifo_info_t const&)in niriok_proxy_impl_v1.cpp.o
:info:build   "uhd::niusrprio::niriok_proxy_impl_v1::NIRIO_RESOURCE::OUTPUT_FIFO", referenced from:
:info:build       uhd::niusrprio::niriok_proxy_impl_v1::add_fifo_resource(uhd::niusrprio::nirio_fifo_info_t const&)in niriok_proxy_impl_v1.cpp.o
:info:build ld: symbol(s) not found for architecture x86_64
:info:build collect2: ld returned 1 exit status

[mail@…]

main.log

[larryv (Lawrence Velázquez)]

Thanks. In future tickets, please Cc any port maintainers (port info --maintainers uhd).

[petrrr]

Cc Me!

[p.ohanlon@…]

It would appear that it may be down to some subtle compiler bug (I'm using /usr/bin/llvm-g++-4.2 on OSX10.7) as when I reimplemented the offending ternary condition using a normal if statement it compiled ok - here's my diff -u:

--- /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_science_uhd/uhd/work/uhd-003_008_000/host/lib/transport/nirio/niriok_proxy_impl_v1.cpp	2014-11-24 11:01:01.000000000 +0000
+++ /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_science_uhd/uhd/work/uhd-003_008_000/host/lib/transport/nirio/niriok_proxy_impl_v1.cpp.orig	2014-11-24 10:59:29.000000000 +0000
@@ -285,10 +285,9 @@
        niriok_proxy_impl_v1::nirio_syncop_out_params_t out = {};

        in.function    = niriok_proxy_impl_v1::NIRIO_FUNC::ADD_RESOURCE;
-       if (fifo_info.direction == OUTPUT_FIFO)
-                in.subfunction = niriok_proxy_impl_v1::NIRIO_RESOURCE::OUTPUT_FIFO;
-       else
-                in.subfunction = niriok_proxy_impl_v1::NIRIO_RESOURCE::INPUT_FIFO;
+       in.subfunction = (fifo_info.direction == OUTPUT_FIFO) ?
+               niriok_proxy_impl_v1::NIRIO_RESOURCE::OUTPUT_FIFO :
+               niriok_proxy_impl_v1::NIRIO_RESOURCE::INPUT_FIFO;

        in.params.add.fifoWithDataType.channel        = fifo_info.channel;
        in.params.add.fifoWithDataType.baseAddress    = fifo_info.base_addr;

[michaelld (Michael Dickens)]

Interesting. I like your way better, and if it works better than that's a double win. Of course, this code isn't actually used on OSX ;)

[michaelld (Michael Dickens)]

Did you maybe diff the wrong way? The code currently reads with the "+" from your patch.

If so, can you try, say, adding "()" around the whole "?" stuff:

((fifo_info.direcion ... ::INPUT_FIFO);

and see if that works? I like the use of "?" here; not sure why it doesn't work.

[michaelld (Michael Dickens)]

Your fix (reverse of the patch above) was the only change I could get to work, and it seems to work well across various compilers.

Thus, I've committed it in r128624, and will push the change to Ettus for their consideration. Thanks!

[p.ohanlon@…]

Replying to michaelld@…:

Did you maybe diff the wrong way? The code currently reads with the "+" from your patch.

If so, can you try, say, adding "()" around the whole "?" stuff:

((fifo_info.direcion ... ::INPUT_FIFO);

and see if that works? I like the use of "?" here; not sure why it doesn't work.

Yeah you're right. Anyway glad it [reversed] fixed it for people.