Opened 10 years ago

Closed 10 years ago

#45840 closed update (fixed)

gcc49: update to 4.9.2

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: larryv (Lawrence Velázquez)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: mww@…
Port: gcc49

Description

Please update: 

$ port livecheck gcc49
gcc49 seems to have been updated (port version: 4.9.1, new version: 4.9.2)

Attachments (3)

Portfile-gcc49.diff​ (1.7 KB) - added by ryandesign (Ryan Carsten Schmidt) 10 years ago.
yosemite-symbol-lookup.patch​ (11.0 KB) - added by ryandesign (Ryan Carsten Schmidt) 10 years ago.
gcc49.diff​ (28.9 KB) - added by larryv (Lawrence Velázquez) 10 years ago.
patch against the ports tree updating gcc49 to @4.9.2, refreshing the symbol lookup patch, and adding a fix for handling of deployment targets

Download all attachments as: .zip

Change History (13)

comment:1 Changed 10 years ago by larryv (Lawrence Velázquez)

Cc: larryv@… added

Cc Me!

Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)

Attachment: Portfile-gcc49.diff​ added

Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)

Attachment: yosemite-symbol-lookup.patch​ added

comment:2 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)

Keywords: haspatch added

Portfile diff attached. Fix-__ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__.patch can be deleted as it seems no longer to be needed. yosemite-symbol-lookup.patch is updated to use -p0 like the other gcc ports do.

comment:3 in reply to:  2 Changed 10 years ago by larryv (Lawrence Velázquez)

Replying to ryandesign@…:

Fix-__ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__.patch can be deleted as it seems no longer to be needed.

Upstream actually ​committed an incorrect fix; our current patch is incorrect also. I’ve just prepared a correct fix, which I will submit upstream as soon as I run some tests.

comment:4 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)

Well, yeah, there is that. If this means we need to fix the patch in all the gcc ports, I would really appreciate it if we could keep the ports as similar as possible, including using the same patchfile name and placing the patchfiles directive at the same point in each portfile.

comment:5 in reply to:  4 Changed 10 years ago by larryv (Lawrence Velázquez)

Replying to ryandesign@…:

If this means we need to fix the patch in all the gcc ports, I would really appreciate it if we could keep the ports as similar as possible, including using the same patchfile name and placing the patchfiles directive at the same point in each portfile.

Sure, that won’t be a problem. That’ll be be easier this time, since I’m actually authoring the fix instead of grabbing it from a mailing list somewhere.

comment:6 in reply to:  2 Changed 10 years ago by larryv (Lawrence Velázquez)

Is there some reason you changed patchfiles to patchfiles-append?

comment:7 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)

Just a habit I'm getting into. Not terribly important.

comment:8 in reply to:  2 Changed 10 years ago by larryv (Lawrence Velázquez)

I’ve updated your changes​ to include ​the deployment target fix that I submitted upstream.

Changed 10 years ago by larryv (Lawrence Velázquez)

Attachment: gcc49.diff​ added

patch against the ports tree updating gcc49 to @4.9.2, refreshing the symbol lookup patch, and adding a fix for handling of deployment targets

comment:9 Changed 10 years ago by larryv (Lawrence Velázquez)

Cc: mww@… added; larryv@… removed
Owner: changed from mww@… to larryv@…
Status: new → assigned

comment:10 Changed 10 years ago by larryv (Lawrence Velázquez)

Resolution: → fixed
Status: assigned → closed

r128280 and r128281, maintainer timeout.

Note: See TracTickets for help on using tickets.