Opened 10 years ago

Closed 7 years ago

#45920 closed defect (fixed)

apache24-devel makes a false replace in config_vars.mk for apr-1/libtool

Reported by: girgen@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.3.2
Keywords: Cc: ryandesign (Ryan Carsten Schmidt), BjarneDMat, pixilla (Bradley Giesbrecht), khepler
Port: apache24-devel

Description

The replace below is already done correctly by the apache source nowadays, so this replace will actually break the file instead of fixing it: 

    # fix libtool path
#    reinplace "s|/build/libtool|/share/apr-1/build/libtool|g" \
#        ${destroot}${apache2.installbuilddir}/config_vars.mk

After the reinplace, the result is /share/apr-1/share/apr-1/build/libtool, which of course is wrong. This makes dependant modules, like mod_jk, to fail at buildtime, since libtool cannot be found.

Just removing the three lines shown above, starting with "# fix libtool patch", fixes the libtool path =)

This patch is needed for mod_jk to build successlfully with apache24.

Attachments (1)

apache24-devel-unreinplace.patch​ (690 bytes) - added by khepler 9 years ago.
Patch to remove apr path reinplace.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: openmaintainer@… removed
Keywords: mod_jk libtool apache removed
Port: apache24-devel added; www/apache24-devel removed
Summary: www/apache24-devel makes a false replace in config_vars.mk for apr-1/libtool → apache24-devel makes a false replace in config_vars.mk for apr-1/libtool

This kind of problem is exactly why I keep advocating for the use of patchfiles instead of reinplaces.

comment:2 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: ryandesign@… pixilla@… added; ryandesign@… pixilla@… removed

comment:3 Changed 9 years ago by khepler

Cc: khepler@… added

Cc Me!

Changed 9 years ago by khepler

Attachment: apache24-devel-unreinplace.patch​ added

Patch to remove apr path reinplace.

comment:4 Changed 7 years ago by Schamschula (Marius Schamschula)

Resolution: → fixed
Status: new → closed

Find in ​https://github.com/macports/macports-ports/commit/12fedbd20c5bd98b3dc91437384886d24ede3f52

Note: See TracTickets for help on using tickets.