Opened 10 years ago
Closed 10 years ago
#46119 closed defect (fixed)
clang-3.6 @3.6-r223943 -arm_runtime: reinplace produces makefile syntax error
Reported by: | ryandesign (Ryan Carsten Schmidt) | Owned by: | larryv (Lawrence Velázquez) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 2.3.3 |
Keywords: | Cc: | jeremyhu (Jeremy Huddleston Sequoia), h.rayflood@… | |
Port: | clang-3.6 |
Description
There seems to be an errant close-parenthesis somewhere:
:info:build MKDIR: /Volumes/Data/macports/snowleopard/var/macports/build/_Volumes_Data_macports_dports_lang_llvm-3.6/clang-3.6/work/trunk/tools/clang/runtime/compiler-rt/clang_darwin/ios/)/SubDir.lib__builtins :info:build mkdir -p /Volumes/Data/macports/snowleopard/var/macports/build/_Volumes_Data_macports_dports_lang_llvm-3.6/clang-3.6/work/trunk/tools/clang/runtime/compiler-rt/clang_darwin/ios/)/SubDir.lib__builtins > /dev/null :info:build MKDIR: /Volumes/Data/macports/snowleopard/var/macports/build/_Volumes_Data_macports_dports_lang_llvm-3.6/clang-3.6/work/trunk/tools/clang/runtime/compiler-rt/clang_darwin/ios/) :info:build mkdir -p /Volumes/Data/macports/snowleopard/var/macports/build/_Volumes_Data_macports_dports_lang_llvm-3.6/clang-3.6/work/trunk/tools/clang/runtime/compiler-rt/clang_darwin/ios/) > /dev/null :info:build /bin/sh: -c: line 0: syntax error near unexpected token `)' :info:build /bin/sh: -c: line 0: syntax error near unexpected token `)' :info:build /bin/sh: -c: line 0: `mkdir -p /Volumes/Data/macports/snowleopard/var/macports/build/_Volumes_Data_macports_dports_lang_llvm-3.6/clang-3.6/work/trunk/tools/clang/runtime/compiler-rt/clang_darwin/ios/) > /dev/null' :info:build /bin/sh: -c: line 0: `mkdir -p /Volumes/Data/macports/snowleopard/var/macports/build/_Volumes_Data_macports_dports_lang_llvm-3.6/clang-3.6/work/trunk/tools/clang/runtime/compiler-rt/clang_darwin/ios/)/SubDir.lib__builtins > /dev/null' :info:build make[4]: *** [/Volumes/Data/macports/snowleopard/var/macports/build/_Volumes_Data_macports_dports_lang_llvm-3.6/clang-3.6/work/trunk/tools/clang/runtime/compiler-rt/clang_darwin/ios/)/.dir] Error 2 :info:build make[4]: *** Waiting for unfinished jobs.... :info:build make[4]: *** [/Volumes/Data/macports/snowleopard/var/macports/build/_Volumes_Data_macports_dports_lang_llvm-3.6/clang-3.6/work/trunk/tools/clang/runtime/compiler-rt/clang_darwin/ios/)/SubDir.lib__builtins/.dir] Error 2 :info:build make[4]: Leaving directory `/Volumes/Data/macports/snowleopard/var/macports/build/_Volumes_Data_macports_dports_lang_llvm-3.6/clang-3.6/work/trunk/projects/compiler-rt' :info:build make[3]: *** [BuildRuntimeLibraries] Error 2 :info:build rm /Volumes/Data/macports/snowleopard/var/macports/build/_Volumes_Data_macports_dports_lang_llvm-3.6/clang-3.6/work/trunk/Release+Debug+Asserts/lib/clang/3.6.0/lib/macho_embedded/.dir /Volumes/Data/macports/snowleopard/var/macports/build/_Volumes_Data_macports_dports_lang_llvm-3.6/clang-3.6/work/trunk/Release+Debug+Asserts/lib/clang/3.6.0/lib/darwin/.dir :info:build make[3]: Leaving directory `/Volumes/Data/macports/snowleopard/var/macports/build/_Volumes_Data_macports_dports_lang_llvm-3.6/clang-3.6/work/trunk/tools/clang/runtime/compiler-rt' :info:build make[2]: *** [compiler-rt/.makeall] Error 2 :info:build make[2]: Leaving directory `/Volumes/Data/macports/snowleopard/var/macports/build/_Volumes_Data_macports_dports_lang_llvm-3.6/clang-3.6/work/trunk/tools/clang/runtime' :info:build make[1]: *** [all] Error 1 :info:build make[1]: Leaving directory `/Volumes/Data/macports/snowleopard/var/macports/build/_Volumes_Data_macports_dports_lang_llvm-3.6/clang-3.6/work/trunk/tools/clang' :info:build make: *** [all] Error 1
Attachments (3)
Change History (19)
Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)
Attachment: | main.log.bz2 added |
---|
comment:1 Changed 10 years ago by larryv (Lawrence Velázquez)
Cc: | larryv@… added |
---|
comment:2 Changed 10 years ago by larryv (Lawrence Velázquez)
Cc: | jeremyhu@… h.rayflood@… added; larryv@… removed |
---|---|
Keywords: | snowleopard lion added |
Owner: | changed from jeremyhu@… to larryv@… |
Summary: | clang-3.6 @3.6-r222672: /bin/sh: -c: line 0: syntax error near unexpected token `)' → clang-3.6 @3.6-r223943: /bin/sh: -c: line 0: syntax error near unexpected token `)' |
Has duplicate #46201.
comment:3 follow-up: 4 Changed 10 years ago by h.rayflood@…
comment:4 Changed 10 years ago by h.rayflood@…
Replying to h.rayflood@…:
this error may caused by http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/make/platform/clang_darwin.mk?r1=221622&r2=221656
oh, sorry. I misunderstood...
comment:5 Changed 10 years ago by larryv (Lawrence Velázquez)
I couldn’t reproduce this on Lion. Initially I was running into a different problem in the same part of the build; after fixing that with r129438, the build completed successfully.
Does that change fix this issue also?
comment:6 follow-ups: 7 9 Changed 10 years ago by h.rayflood@…
no, r129438 cannot fix this issue.
info:
my filesystem:
hfs+, journaling, case-sensitive
$ make --version
GNU Make 3.81
$ ./port variants clang-3.6
clang-3.6 has the variants:
[+]analyzer: Install clang static analyzer
(-)arm_runtime: Build and install the arm runtime for iOS development (requires iOS SDK)
(+)assertions: Enable assertions for error detection (has performance impacts, especially on JIT)
universal: Build for multiple architectures
$ cat ../etc/macports/variants.conf
+perl5_8 +assertions -arm_runtime
comment:7 follow-up: 8 Changed 10 years ago by larryv (Lawrence Velázquez)
Replying to h.rayflood@…:
no, r129438 cannot fix this issue.
“Cannot”? Do you mean “did not”? Did you actually run selfupdate and try building again? If so, please attach a new complete log.
Changed 10 years ago by h.rayflood@…
comment:9 follow-ups: 11 13 Changed 10 years ago by larryv (Lawrence Velázquez)
Okay, so both you and Ryan are disabling the arm_runtime
variant. I suspect that this bit of the portfile is not behaving as expected:
post-patch { if {${subport} eq "clang-${llvm_version}"} { # http://trac.macports.org/ticket/33272 if {![variant_isset arm_runtime]} { reinplace {/^SubDirs/ s/arm//} ${worksrcpath}/projects/compiler-rt/lib/Makefile.mk reinplace {/^UniversalArchs/ s/arm[^ )]* *//g} ${worksrcpath}/projects/compiler-rt/make/platform/clang_darwin.mk reinplace {/cc_kext_ios5/ s/^/#/} ${worksrcpath}/projects/compiler-rt/make/platform/clang_darwin.mk reinplace {s/cc_kext_ios5.a//} ${worksrcpath}/tools/clang/runtime/compiler-rt/Makefile }
comment:10 Changed 10 years ago by larryv (Lawrence Velázquez)
Keywords: | snowleopard lion removed |
---|---|
Summary: | clang-3.6 @3.6-r223943: /bin/sh: -c: line 0: syntax error near unexpected token `)' → clang-3.6 @3.6-r223943 -arm_runtime: reinplace produces makefile syntax error |
Ugh, this is why I hate reinplaces.
Changed 10 years ago by h.rayflood@…
Attachment: | clang_darwin-remove_arm.diff added |
---|
comment:11 follow-up: 12 Changed 10 years ago by h.rayflood@…
Replying to larryv@…:
Okay, so both you and Ryan are disabling the
arm_runtime
variant. I suspect that this bit of the portfile is not behaving as expected:post-patch { if {${subport} eq "clang-${llvm_version}"} { # http://trac.macports.org/ticket/33272 if {![variant_isset arm_runtime]} { reinplace {/^SubDirs/ s/arm//} ${worksrcpath}/projects/compiler-rt/lib/Makefile.mk reinplace {/^UniversalArchs/ s/arm[^ )]* *//g} ${worksrcpath}/projects/compiler-rt/make/platform/clang_darwin.mk reinplace {/cc_kext_ios5/ s/^/#/} ${worksrcpath}/projects/compiler-rt/make/platform/clang_darwin.mk reinplace {s/cc_kext_ios5.a//} ${worksrcpath}/tools/clang/runtime/compiler-rt/Makefile }
I attached a patch. thanks for your advise.
this error occurred from http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/make/platform/clang_darwin.mk?r1=221610&r2=221621
comment:12 Changed 10 years ago by larryv (Lawrence Velázquez)
Thanks, but this is just papering over the actual problem. I’m going to get rid of the substitutions altogether.
comment:13 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)
Replying to larryv@…:
Okay, so both you and Ryan are disabling the
arm_runtime
variant.
I'm just using the default variants. Looks like the arm_runtime variant is default with Xcode 4 and later. On Snow Leopard I have Xcode 3.2.6.
comment:14 Changed 10 years ago by larryv (Lawrence Velázquez)
Okay, I reproduced the -arm_runtime
failure and fixed it with r129516. Please verify.
comment:16 Changed 10 years ago by larryv (Lawrence Velázquez)
Resolution: | → fixed |
---|---|
Status: | new → closed |
The Snow Leopard buildslave built it successfully also.
Cc Me!