bladeRF: Improve version strings

[jon.szymaniak@…]

Currently, the bladeRF (libbladeRF and bladeRF-cli) build attempts to gather information from git, which it does not find during a Macports build. This results in version strings like this, which don't offer any additional information and may be concerning to users.

bladeRF> version

  bladeRF-cli version:        0.12.0-git-unknown
  libbladeRF version:         0.17.0-git-unknown

This "-git-unknown" suffix can be removed by adding the following to the port's configure.args-append:

-DVERSION_INFO_EXTRA=""

However, I think it would be very useful if we instead applied a meaningful MacPorts version annotation via -DVERSION_INFO_OVERRIDE.

I can say with great certainty that this would be helpful in situations where I've seen where folks end up confused because they've got libbladeRF installed in multiple places (one from MacPorts, another from a previous source build) and some PATH or dyld path confusion.

Therefore, I propose appending the following to configure.args-append.

-DVERSION_INFO_OVERRIDE="-MacPorts-${version}"

In this case, I intended ${version} to be the Port version. My syntax may be incorrect, but I suspect this gets the point across. The point is to have versions read back like this:

bladeRF> version

  bladeRF-cli version:        0.12.0-MacPorts-20141120
  libbladeRF version:         0.17.0-MacPorts-20141120

Note that there's no need to touch -DVERSION_INFO_EXTRA in this case, as -DVERSION_INFO_OVERRIDE takes priority.

For what it's worth, I've attempted to ​document this a bit here, as none of this is obvious otherwise.

[jon.szymaniak@…]

My apologies, I failed to CC the port maintainer. Given that I don't see a way to update the ticket, I'll touch base with him offline to note the creation of this ticket.

Update: Nevermind - Thank you larryv!

[larryv (Lawrence Velázquez)]

This sounds like a pretty good idea.

[michaelld (Michael Dickens)]

Excellent idea. I'll add that with the next upgrade tonight. Thanks for pointing this out; I had no idea.

[michaelld (Michael Dickens)]

Done in r129364.