Opened 10 years ago
Closed 4 years ago
#46563 closed defect (fixed)
sslh 1.16 doesn't build on 10.6
Reported by: | spam@… | Owned by: | amake (Aaron Madlon-Kay) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 2.3.3 |
Keywords: | snowleopard leopard tiger | Cc: | ryandesign (Ryan Carsten Schmidt) |
Port: | sslh |
Description
sslh switched to memmem from strstr which doesn't exist on 10.6. It would be nice to have this updated, either to DEFINE memmem(W,X,Y,Z) = strstr(W,Y) when memmem isn't available, or to link to glibc as the threads on sslh spoke of.
This is the change that introduced memmem: https://github.com/yrutschle/sslh/commit/708c3b0177532044b74fc3581fb25c6734831e9b
This is the start of the discussion on memmem, although it spans months, so you may have to work to see more of the convo: http://rutschle.net/pipermail/sslh/2014-March/000501.html
Change History (6)
comment:1 Changed 10 years ago by spam@…
Cc: | spam@… added |
---|
comment:2 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)
Cc: | spam@… removed |
---|---|
Keywords: | snowleopard leopard tiger added |
Owner: | changed from macports-tickets@… to macports@… |
It would typically be the responsibility of the developer of sslh to make any such change. Once they've done that and released a new version including that change, we can update the port in MacPorts to that version.
comment:3 Changed 10 years ago by amake (Aaron Madlon-Kay)
You might as well raise this as an issue on GitHub.
comment:4 Changed 10 years ago by spam@…
Being that it has already been discussed by the maintainer on the mailing list, I think it would be redundant to pester them more.
comment:5 Changed 4 years ago by ryandesign (Ryan Carsten Schmidt)
Cc: | ryandesign added |
---|---|
Owner: | changed from macports@… to amake |
Status: | new → assigned |
I added the legacysupport portgroup to this port in [24c8487350c02c00ea107714ef4802cd6a26083e/macports-ports] but that didn't work (or doesn't work anymore) because this port doesn't pass MacPorts CFLAGS/LDFLAGS to the build system -- which it should be fixed to do.
I have filed an upstream issue here: https://github.com/yrutschle/sslh/issues/278
comment:6 Changed 4 years ago by ryandesign (Ryan Carsten Schmidt)
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Cc Me!