git, openbrowser, ossp-uuid, xraylib: remove variants perl5_12, perl5_14, introduce support for 5.18, 5.20 and 5.22

[mojca (Mojca Miklavec)]

Support for Perl < 5.16 has been removed (#46322). I would like to request removing variants perl5_10, perl5_12, perl5_14 and introduce variants for 5.18, 5.20 and 5.22, ideally using something like this (if I understand the functionality properly):

perl5.require_variant yes 
perl5.conflict_variants yes 
perl5.branches 5.16 5.18 5.20 5.22
perl5.create_variants ${perl5.branches}

I added biblatex-biber and intltool to the list just because it would be nice to use the functionality from the PortGroup rather than "reinventing the wheel" in every port separately.

(See also #43193, r125264, r129992. And maybe we need some documentation about that functionality.)

[mojca (Mojca Miklavec)]

A patch to use perl5_xy variants from the Perl PortGroup in git

[mojca (Mojca Miklavec)]

I attached a sample patch for git. Please check it out and provide feedback.

[ryandesign (Ryan Carsten Schmidt)]

I am not familiar with the variant-creating abilities that were added to the perl5 portgroup, and I haven't tested your patch, but yes certainly please make any such change that you feel is correct to my ports. I've made openbrowser openmaintainer now.

I took a quick look at the patch and at the portgroup. It seems like both the port and the portgroup are overwriting depends_lib. Shouldn't they both be appending to it instead?

[mojca (Mojca Miklavec)]

I forgot to replace depends_lib with depend_lib-append in the patch (and forgot to remove perl5 from dependencies).

You are probably right about the PortGroup, but I wonder why -append is not used anywhere else in the PortGroup either. Is r131727 OK?

[mojca (Mojca Miklavec)]

Ryan, can you please check the attachment with the patch for openbrowser?

[ci42]

Mojca, thanks for the patch. Applied to the git port in r131755.

[mojca (Mojca Miklavec)]

A small cosmetic patch to fix dependencies for git

[mojca (Mojca Miklavec)]

Replying to ciserlohn@…:

Applied to the git port in r131755.

Thank you. Just a cosmetic patch: can you please take a look at the attached git-perl-dependencies.diff​?

If you use depends_lib-append instead of depends_lib, then you can omit the dependency on port:perl${perl5.major} which is already added by the PortGroup. And there is both depends_run and depends_run-append one after the other while they could be joined together. (I didn't sort the dependencies alphabetically to make it more clear what I have done.)

[ci42]

Replying to mojca@…:

Replying to ciserlohn@…:

Applied to the git port in r131755.

Thank you. Just a cosmetic patch: can you please take a look at the attached git-perl-dependencies.diff​?

If you use depends_lib-append instead of depends_lib, then you can omit the dependency on port:perl${perl5.major} which is already added by the PortGroup. And there is both depends_run and depends_run-append one after the other while they could be joined together. (I didn't sort the dependencies alphabetically to make it more clear what I have done.)

r131814

[mojca (Mojca Miklavec)]

intltool changed in r131816.

[mojca (Mojca Miklavec)]

I have a question for pixilla: what is the difference between perl5.require_variant and perl5.set_default_variant?

I thought that perl5.require_variant no would create a bunch of variants without adding one by default, but it has no effect. It only has an effect if I set perl5.set_default_variant to no, but then I don't understand the difference between the two. Is this a bug?

I'm attaching a patch for xraylib. It has a tiny flaw: one perl variant is enforced, but I would like to clarify what the functionality is supposed to be and then it should be trivial to fix that part. I would be grateful if the maintainer of xraylib could review the patch and possibly correct it in case of problems.

[mojca (Mojca Miklavec)]

A patch to use perl5_xy variants from the Perl PortGroup in xraylib

[mojca (Mojca Miklavec)]

Another question for pixilla: I currently used a dirty hack, namely:

if {[variant_isset perl5_16] || [variant_isset perl5_18] || [variant_isset perl5_20]} {

What's the more elegant way to check whether an optional perl variant has been selected?

[Tom.Schoonjans@…]

Thanks for updating the xraylib Portfile. Ideally, the perl bindings would be optional and off by default, like it was before. Unfortunately I cannot test it since I no longer have access to a MacPorts installation.

[mojca (Mojca Miklavec)]

Replying to Tom.Schoonjans@…:

Ideally, the perl bindings would be optional and off by default, like it was before.

I totally agree. But I need to ask Bradley: maybe there's a bug in the PortGroup that needs to be fixed before committing this change.

Unfortunately I cannot test it since I no longer have access to a MacPorts installation.

How does that affect your maintainership of the port? Are you still willing to maintain the port?

[Tom.Schoonjans@…]

Sure, I will continue to file updates for the ports I am maintaining

[mojca (Mojca Miklavec)]

Replying to ryandesign@…:

I am not familiar with the variant-creating abilities that were added to the perl5 portgroup, and I haven't tested your patch, but yes certainly please make any such change that you feel is correct to my ports. I've made openbrowser openmaintainer now.

I committed the changes for openbrowser in r131840.

[mojca (Mojca Miklavec)]

It's not clear to me whether Perl in ossp-uuid is "required" or not. The Portfile is written as if it was optional, but then it picks +perl5_16.

[pixilla (Bradley Giesbrecht)]

Replying to mojca@…:

I have a question for pixilla: what is the difference between perl5.require_variant and perl5.set_default_variant?

perl5.require_variant yes will produce an error if a perl variant is not selected, say someone does "port install foo -perl5_20" to negate a default +perl5_20.

perl5.default_variant is always set to a perl variant and defaults to perl5.default_branch, one can set perl5.default_variant to something else in the Portfile. perl5.default_variant may be redundant since perl5.default_branch can achieve the same effect.

perl5.set_default_variant is used to control whether to actually set a default perl variant.

[pixilla (Bradley Giesbrecht)]

Replying to mojca@…:

Another question for pixilla: I currently used a dirty hack, namely:

if {[variant_isset perl5_16] || [variant_isset perl5_18] || [variant_isset perl5_20]} {

What's the more elegant way to check whether an optional perl variant has been selected?

With patch-portgroup-perl5.diff​​ perl5.variant should be set to the name of the selected variant or empty if there is not one:

perl5.branches          5.16 5.18 5.20
perl5.create_variants   ${perl5.branches}
puts "perl5.variant: ${perl5.variant}"

[mojca (Mojca Miklavec)]

Bradley, are you willing to commit the change of the PortGroup? I still have the modification of xraylib pending here because I'm unable to leave the perl variant unselected, but I don't feel comfortable enough doing the commit myself.

[mojca (Mojca Miklavec)]

I added support for 5.22 to git in r138632. I hope that's ok (a very minor change).

[mojca (Mojca Miklavec)]

Support for openbrowser committed in r138633.

[dbevans (David B. Evans)]

Added +perl5_22 variant to intltool in r138638, r138640 although I'm considering removing its perl variants entirely. Using the default perl should be sufficient here.

[mojca (Mojca Miklavec)]

Use the code from PortGroup to create the variants for biblatex-biber, add Perl 5.22

[mojca (Mojca Miklavec)]

Dan, can you please check the attached patch for biblatex-biber?

[dbevans (David B. Evans)]

ossp-uuid perl variants updated in r142680, default variant is possibly required by rpm52 rpm53 rpm54 (unverified).

[dbevans (David B. Evans)]

percona-toolkit also needs attention (#49883).

[dbevans (David B. Evans)]

patch for xraylib committed in r143200 with maintainer's approval above.

[dbevans (David B. Evans)]

log2timeline: +perl5_22 variant added in r143201.
sqlgrey: +perl5_22 variant added in r143202.

All ports with perl variants now updated as requested in this ticket.