Opened 10 years ago

Closed 10 years ago

#46754 closed defect (fixed)

llvm-3.* does not recognize -assertions

Reported by: pguyot (Paul Guyot) Owned by: jeremyhu (Jeremy Huddleston Sequoia)
Priority: Normal Milestone:
Component: ports Version: 2.3.3
Keywords: Cc: larrryv@…
Port: llvm-3.3 llvm-3.4 llvm-3.5 llvm-3.6 llvm-3.7

Description (last modified by pguyot (Paul Guyot))

Even when -assertions is passed, assertion mode is ON.

I believe --enable-assertions is NOP and --disable-assertions should be passed instead as assertions are enabled by default. This is also the case with at least 3.7 and 3.5 and maybe other versions as well.

./configure --help indeed prints: 

  --enable-assertions     Compile with assertion checks enabled (default is
                          YES)

A patch is attached that fixes this for llvm-3.6. I didn't bump revision, though. Yet, bumping revision is required at least for llvm-3.5 as the -assertions variant is available as a binary package (but with assertion-mode as ON).

Attachments (1)

llvm-assertions.diff​ (853 bytes) - added by pguyot (Paul Guyot) 10 years ago.

Download all attachments as: .zip

Change History (6)

Changed 10 years ago by pguyot (Paul Guyot)

Attachment: llvm-assertions.diff​ added

comment:1 Changed 10 years ago by pguyot (Paul Guyot)

Description: modified (diff)
Summary: llvm-3.6 does not recognize -assertions → llvm-3.* does not recognize -assertions

comment:2 Changed 10 years ago by pguyot (Paul Guyot)

Description: modified (diff)
Port: llvm-3.5 llvm-3.6 llvm-3.7 added; llvm removed

comment:3 Changed 10 years ago by larryv (Lawrence Velázquez)

Cc: larrryv@… added
Port: llvm-3.5, llvm-3.6, llvm-3.7 → llvm-3.5 llvm-3.6 llvm-3.7

comment:4 Changed 10 years ago by jeremyhu (Jeremy Huddleston Sequoia)

Port: llvm-3.3 llvm-3.4 added
Status: new → assigned

Yep, it also impacts 3.3 and 3.4. I'll be updating this soon.

comment:5 Changed 10 years ago by jeremyhu (Jeremy Huddleston Sequoia)

Resolution: → fixed
Status: assigned → closed

r132960

Note: See TracTickets for help on using tickets.