FileZilla @3.8.1_1: update to 3.10.1.1

[asedeno@…]

Attached is a patch to bring the FileZilla up to date.

• update to 3.10.1.1
• sources from svn tagged releases
• clean up temporary wxwidget changes
• remove unneeded patch to configure
• add patch for include bug introduced upstream in 3.10.1.1. (I'll be filing a bug upstream shortly.)

[larryv (Lawrence Velázquez)]

Thanks. In future tickets, please Cc any port maintainers (port info --maintainers FileZilla).

• Since you’re increasing version, revision should be removed or set to “0”.
• SourceForge appears to host FileZilla’s ​source distfile. The portfile should fetch from there instead of doing a Subversion checkout.

[mojca (Mojca Miklavec)]

I have some problems maintaining FileZilla after the developer switched to C++11 (and until I finish the work I'm currently doing I cannot afford to spend days upgrading my OS). I have another machine with a libc++-based MacPorts installation where I can theoretically test. Or I could try building it against wxWidgets-3.0-libcxx. And even with all that trickery in place I still experienced many problems with functionality of FileZilla built against wxWidgets 3.0 last time when I tried.

The sources should be fetched from SourceForge, not from SVN, as already noted. And no autoreconf should be use. We also need some special care if we want to keep supporting libc++-based installations on OS X < 10.9.

If anyone would like to take over the maintainership, feel free to do so. I can commit "blind" untested patches, but I'm uncomfortable doing that. I should at least enable the libc++-based build.

[asedeno@…]

Yeah, sorry about failing to CC. By the time I realized it, it was past the point where I could add a CC to the ticket. My only modification options were to leave the ticket as new.

• revision: removed
• master_sites: sourceforce
• autoreconf: removed

I'm new to the whole mac thing, so all I have on hand for testing is 10.10. Suggestions accepted.

[mojca (Mojca Miklavec)]

I'm getting the following configure error (on 10.7):

checking for wxWidgets static library... no
checking positional printf argument support in wxWidgets... no
configure: error: Positional printf argument support in wxWidgets is required by FileZilla. Please rebuild wxWidgets and pass --enable-printfposparam to its configure script.

I need to check and possibly modify wxWidgets. Did it work out of the box for you?

[asedeno@…]

It worked out of the box for me on 10.10. I don't have anything older to test on at the moment.

[mojca (Mojca Miklavec)]

Thank you. I'll try to recompile wxWidgets first, then I'll try to figure out what's the reason for a different behaviour on the two version of the OS, and also try to figure out if it works at all for me.

[mojca (Mojca Miklavec)]

I found the problem, but I'm not sure about the proper solution yet. The following chunk ignores CXXFLAGS and fails because of missing -stdlib settings:

  AC_LANG_PUSH(C++)
  CPPFLAGS_OLD="$CPPFLAGS"
  CPPFLAGS="$CPPFLAGS $WX_CPPFLAGS"
  AC_MSG_CHECKING([positional printf argument support in wxWidgets])
  AC_PREPROC_IFELSE(
    [AC_LANG_PROGRAM([[
          #include <wx/wx.h>
          #if !wxUSE_PRINTF_POS_PARAMS
            #error wx compiled without wxUSE_PRINTF_POS_PARAMS
          #endif
        ]])],
      AC_MSG_RESULT([yes]),
      [
        AC_MSG_RESULT([no])
        AC_MSG_FAILURE([Positional printf argument support in wxWidgets is required by FileZilla. Please rebuild wxWidgets and pass --enable-printfposparam to its configure script.])
      ]
    )
  CPPFLAGS="$CPPFLAGS_OLD"
  AC_LANG_POP

[mojca (Mojca Miklavec)]

I committed the upgrade in r132922, but I need to find a fix for the above mentioned problem for < 10.9.

[mojca (Mojca Miklavec)]

A workaround in r132937. A proper fix needs to be applied upstream though.