Opened 10 years ago
Closed 10 years ago
#46773 closed update (fixed)
Update: libktorrent 1.3.1
Reported by: | Schamschula (Marius Schamschula) | Owned by: | macports-tickets@… |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | |
Keywords: | haspatch | Cc: | mkae (Marko Käning), NicosPavlov |
Port: | libktorrent |
Description (last modified by ryandesign (Ryan Carsten Schmidt))
libktorrent has been updated to version 1.3.1. Notes:
homepage
andmaster_sites
have been updated.- There is a build issue with the current version of boost (1.57.0) which affects libktorrent builds (old and new versions): I had to manually edit /opt/local/include/boost/type_traits/detail/has_binary_operator.hpp according to to an answer found in
http://stackoverflow.com/questions/15455178/qt4-cgal-parse-error-at-boost-join
i.e. add
#ifndef Q_MOC_RUN
to the top and #endif to the bottom of the header file.
Attachments (1)
Change History (7)
Changed 10 years ago by Schamschula (Marius Schamschula)
Attachment: | Portfile-libktorrent.diff added |
---|
comment:1 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)
Description: | modified (diff) |
---|
comment:3 Changed 10 years ago by neverpanic (Clemens Lang)
I resolved a similar problem in gerbil by just putting the #include of the header defining BOOST_JOIN between #ifdef Q_MOC_RUN
and #endif
. It seems moc doesn't really care about the missing header.
comment:4 Changed 10 years ago by neverpanic (Clemens Lang)
See http://tracker.gerbilvis.org/index.php?do=details&task_id=109 for more details on how I fixed this in gerbil.
comment:5 Changed 10 years ago by mkae (Marko Käning)
Cc: | nicos@… added |
---|---|
Version: | 2.3.3 |
comment:6 Changed 10 years ago by NicosPavlov
Resolution: | → fixed |
---|---|
Status: | new → closed |
Thank you for the input and the detailed report. Committed in r135517.
Note: See
TracTickets for help on using
tickets.
I'm not wild about patching boost files to deal with this problem, since it's really a Qt bug, fixed in Qt 5. Unfortunately, the ticket does not say what commit(s) fixed the problem. Possibly the moc compiler got substantial changes in Qt 5 which happened to fix this, and back-porting it to Qt 4 would be unfeasible.
Could libktorrent use qt5-mac instead of qt4-mac?