Updating cmake @3.0.2_1+gui fails

[willic3@…]

I did a selfupdate a couple of days ago, and the new version of cmake is unable to get past the patching stage:

--->  Fetching distfiles for cmake
--->  Verifying checksums for cmake
--->  Checksumming cmake-3.1.3.tar.gz
--->  Extracting cmake
--->  Extracting cmake-3.1.3.tar.gz
--->  Applying patches to cmake
--->  Applying patch-CMakeFindFrameworks.cmake.diff
patching file Modules/CMakeFindFrameworks.cmake
--->  Applying patch-Modules-FindFreetype.cmake.diff
patching file Modules/FindFreetype.cmake
--->  Applying patch-Modules-FindQt4.cmake.diff
patching file Modules/FindQt4.cmake
--->  Applying patch-Modules-Platform-Darwin.cmake.diff
patching file Modules/Platform/Darwin.cmake
--->  Applying patch-Modules-Platform-Darwin-Initialize.cmake.diff
patching file Modules/Platform/Darwin-Initialize.cmake
--->  Applying patch-Modules-noArchCheck.diff
patching file Modules/BasicConfigVersion-AnyNewerVersion.cmake.in
patching file Modules/BasicConfigVersion-ExactVersion.cmake.in
patching file Modules/BasicConfigVersion-SameMajorVersion.cmake.in
--->  Applying patch-CMakeLists.txt.diff
patching file CMakeLists.txt
Hunk #1 FAILED at 476.
1 out of 1 hunk FAILED -- saving rejects to file CMakeLists.txt.rej
patching file Source/QtDialog/CMakeLists.txt
Hunk #1 succeeded at 125 (offset 26 lines).
Hunk #2 succeeded at 141 (offset 26 lines).
Hunk #3 FAILED at 179.
Hunk #4 succeeded at 184 (offset 18 lines).
1 out of 4 hunks FAILED -- saving rejects to file Source/QtDialog/CMakeLists.txt.rej
Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_devel_cmake/cmake/work/cmake-3.1.3" && /usr/bin/patch -p0 < '/opt/local/var/macports/sources/rsync.macports.org/release/tarballs/ports/devel/cmake/files/patch-CMakeLists.txt.diff'
Exit code: 1
Error: org.macports.patch for port cmake returned: command execution failed
Warning: targets not executed for cmake: org.macports.install org.macports.patch org.macports.configure org.macports.build org.macports.destroot
Please see the log file for port cmake for details:
    /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_devel_cmake/cmake/main.log
Error: Unable to upgrade port: 1
To report a bug, follow the instructions in the guide:
    http://guide.macports.org/#project.tickets

Looking back in the old tickets, it appears this problem has occurred before.

Thanks, Charles

[mf2k (Frank Schima)]

In the future, please use WikiFormatting and Cc the port maintainers (port info --maintainers cmake), if any.

[michaelld (Michael Dickens)]

Looks like I missed the +gui patch when updating to 3.1.3. My bad. I'll fix it up shortly.

[michaelld (Michael Dickens)]

Has duplicate #46919.

[michaelld (Michael Dickens)]

I just attached a patch that seems to work for me to fix the cmake +gui issue. It should allow for building using +qt4 or +qt5. Please try out this patch and provide feedback! This patch was created using "svn diff", so you'd apply it using "patch -p0".

[RJVB (René Bertin)]

Looks like the same issue I had to work around in cmake 3.1.2 (?)

[willic3@…]

Thanks! That patch seemed to work fine for me (using qt4).

Replying to michaelld@…:

I just attached a patch that seems to work for me to fix the cmake +gui issue. It should allow for building using +qt4 or +qt5. Please try out this patch and provide feedback! This patch was created using "svn diff", so you'd apply it using "patch -p0".

[michaelld (Michael Dickens)]

@rjvbertin: yes; I chose different variants and patches, but the same basic concept. Can you test with "+gui +qt5"? (and "+gui +qt4" if you want; but, that seems to work).

@willic3: Great; thanks for the feedback! It works for me with "+gui +qt4" as well.

[RJVB (René Bertin)]

I hope to be able to do what you asked re: cmake 3.1.2 last week. That version I did test with both qt4 and qt5.

[onurdomanic@…]

Cc Me!

[michaelld (Michael Dickens)]

I went ahead and committed this change in r133527.