Opened 10 years ago

Closed 9 years ago

Last modified 9 years ago

#47051 closed enhancement (fixed)

pass @1.6.5 add variant for gnupg21 dependency

Reported by: edwin@… Owned by: john@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: Ionic (Mihai Moldovan), ryandesign (Ryan Carsten Schmidt)
Port: pass

Description

this patch is based on updated Portfile from ticket #47050

adds support for the new GnuPG 2.1.x port

variant description could be better

Attachments (1)

Portfile-pass_gnupg21.diff (1.3 KB) - added by edwin@… 10 years ago.

Download all attachments as: .zip

Change History (7)

Changed 10 years ago by edwin@…

Attachment: Portfile-pass_gnupg21.diff added

comment:1 Changed 10 years ago by john@…

Thanks for this too.

However, rather than introducing a variant, I think a bin dependency would be the way to go. That is:

depends_run bin:gpg2:gnupg2

This will use the gpg2 executable provided by either gnupg2 or gnupg21 if one is installed, or otherwise install gnupg2.

Note that I've not actually tried this in practice -- I'll do so when I get chance, but feel free to see if it works for you and submit a new patch if you have time.

comment:2 Changed 10 years ago by john@…

I've added a dependency of the sort I suggest to the updated portfile in #47050. I prefer that to the variant originally suggested here.

comment:3 Changed 10 years ago by mf2k (Frank Schima)

Cc: john@… removed
Owner: changed from macports-tickets@… to john@…
Version: 2.3.3

comment:4 Changed 9 years ago by Ionic (Mihai Moldovan)

Cc: ionic@… added
Resolution: fixed
Status: newclosed

Fixed by r138163.

comment:5 Changed 9 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: ryandesign@… added

A bin:-style dependency should only be used if you want to allow a binary outside of MacPorts to be able to satisfy the dependency. Usually we do not want that. If you only want to allow binaries provided by MacPorts ports to satisfy the dependency, but there are multiple ports that could provide it, then use a path:-style dependency (path:bin/gpg2:gnupg2).

comment:6 Changed 9 years ago by Ionic (Mihai Moldovan)

Updated in r138311.

It shouldn't make a big difference, though, as Apple doesn't (yet) ship any gnupg version. Problems with MacGPG, which installs to /usr/local, are unlikely because the default PATH value for MacPorts does not include /usr/local/bin.

Note: See TracTickets for help on using tickets.