Opened 10 years ago
Closed 10 years ago
#47387 closed update (fixed)
tidy: update to 4.9.24
Reported by: | macports_org@… | Owned by: | ryandesign (Ryan Carsten Schmidt) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 2.3.3 |
Keywords: | haspatch | Cc: | Ionic (Mihai Moldovan) |
Port: | tidy |
Description (last modified by Ionic (Mihai Moldovan))
Please update HTML Tidy. There are much more recent versions than what was available in 2012!
Note: I understand from an IRC conversation with "Ionic" that they aren't properly tagging their releases in GitHub. I'm also contacting them to ask them to start doing this. :-)
http://www.html-tidy.org
https://github.com/htacg/tidy-html5
Attachments (2)
Change History (15)
comment:1 Changed 10 years ago by Ionic (Mihai Moldovan)
Owner: | changed from macports-tickets@… to ryandesign@… |
---|---|
Port: | tidy added |
comment:2 Changed 10 years ago by larryv (Lawrence Velázquez)
Description: | modified (diff) |
---|
comment:3 Changed 10 years ago by Ionic (Mihai Moldovan)
Description: | modified (diff) |
---|
comment:4 Changed 10 years ago by larryv (Lawrence Velázquez)
The project does have “versions” of sorts, so it might be feasible to switch over to proper version numbers (although we’d still have to fetch Git commits).
https://github.com/htacg/tidy-html5/blob/master/version.txt
comment:5 Changed 10 years ago by Ionic (Mihai Moldovan)
Owner: | changed from ryandesign@… to ionic@… |
---|---|
Status: | new → assigned |
Turns out the port was updated, but the version not incremented. Doing that myself now.
comment:6 Changed 10 years ago by Ionic (Mihai Moldovan)
Owner: | changed from ionic@… to ryandesign@… |
---|---|
Status: | assigned → new |
Rather turns out I cannot read, as always. While r131697 did change the github.setup
line, the commit ID was left intact, so the port is still in its stale 2012 state. Re-assigning back, sorry for all the noise...
comment:7 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)
Status: | new → assigned |
---|
In January, the developer of tidy asked me to change the tidy port to build via cmake or Xcode, and said version 5.0.0 would be released within weeks, but it does not appear to have happened yet. I'll look into updating to a newer development version.
comment:8 follow-up: 9 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)
Keywords: | haspatch added |
---|---|
Summary: | update HTML Tidy → tidy: update to 4.9.24 |
Not sure when it changed, but compared with the 2012 version we currently have in MacPorts, in the current 4.9.24 version, the program name has changed from tidy
to tidy5
and the library name has changed from libtidy
to libtidy5
. We have several ports declaring dependencies on the tidy port. I suspect they may need to be updated for these changes. I'll attach my portfile update for tidy so far but won't commit it until I've tested and fixed ths dependents.
Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)
Attachment: | patch-CMakeLists.txt.diff added |
---|
Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)
Attachment: | tidy-4.9.24.diff added |
---|
comment:9 Changed 10 years ago by macports_org@…
Replying to ryandesign@…:
Compared with the 2012 version we currently have in MacPorts, in the current 4.9.24 version, the program name has changed from
tidy
totidy5
and the library name has changed fromlibtidy
tolibtidy5
.
You may want to hold off for a release. That MAY be just for testing/beta purposes -- I believe I saw discussion on that site that the program would remain "tidy".
comment:10 Changed 10 years ago by macports_org@…
Here it is: https://github.com/htacg/tidy-html5/issues/46
The name will remain just "tidy".
EDIT TO ADD: Especially note one of the later comments, regarding a script to assist the reversion. Maybe useful to MacPorts?
comment:11 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)
Thanks, that does work. I can edit the CMakeLists.txt to change the variable from tidy5
back to tidy
. Now I just need to test other ports to make sure they still work with this new version of tidy.
comment:12 Changed 10 years ago by Ionic (Mihai Moldovan)
Cc: | ionic@… added |
---|
comment:13 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Also being a jerk about the nickname and everything.