Opened 10 years ago
Closed 10 years ago
#47421 closed update (fixed)
imlib2 @1.4.6_1: update to 1.4.7
| Reported by: | Schamschula (Marius Schamschula) | Owned by: | ryandesign (Ryan Carsten Schmidt) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.3.3 |
| Keywords: | haspatch | Cc: | |
| Port: | imlib2 |
Description
imlib2 has been updated to version 1.4.7. No longer need patch-imlib2-config.in.diff as it has been included upstream.
Attachments (1)
Change History (4)
Changed 10 years ago by Schamschula (Marius Schamschula)
| Attachment: | Portfile-imlib2.diff added |
|---|
comment:1 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)
| Owner: | changed from macports-tickets@… to ryandesign@… |
|---|---|
| Status: | new → assigned |
comment:2 Changed 10 years ago by Schamschula (Marius Schamschula)
I don't build universal, so I have no idea, Maybe Jeremy, who committed that patch can make that judgement.
comment:3 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
I do build universal, and imlib2 1.4.7 builds fine for me universal without autoreconf. At r43202, imlib2 was at version 1.4.1 and its bundled configure script was generated by autoconf 2.59, copyright 2003, which was several years before Intel Macs and universal binaries were introduced, so it likely did not understand how to do a universal build. At that time, the version of the autoconf port was 2.63, so regenerating the configure script with autoconf 2.63 must have been sufficient for it to understand universal builds. Now, imlib2 1.4.7's bundled configure script was generated by autoconf 2.69, so that is already sufficiently new to build universal. If there is some other known reason why autoreconf is still needed, we can put it back in, but for now, I'm removing it.
Updated in r135289. Thanks!
Does it still need to use autoreconf? That's been in the port since r43202 when it was added to teach it how to build universal; surely that reason no longer applies.