Opened 10 years ago

Closed 10 years ago

#47445 closed defect (fixed)

rpm54: fails patch phase in trace mode

Reported by: Ionic (Mihai Moldovan) Owned by: n3npq@…
Priority: Normal Milestone:
Component: ports Version: 2.3.99
Keywords: tracemode haspatch Cc:
Port: rpm54

Description (last modified by Ionic (Mihai Moldovan))

rpm54 is currently changing files in post-patch via reinplace (OK) and also running glibtoolize.

glibtoolize is not available in the phases fetch, extract or patch.

In any case, the glibtoolize call should really be part of pre-configure, where glibtoolize will be available. That's also semantically the proper way to regenerate stuff prior to configure.

The (soon) attached trivial patch fixes that problem.

Attachments (1)

rpm54.diff​ (403 bytes) - added by Ionic (Mihai Moldovan) 10 years ago.
Run glibtoolize in pre-configure instead of post-patch. Fixes builds in trace mode.

Download all attachments as: .zip

Change History (3)

Changed 10 years ago by Ionic (Mihai Moldovan)

Attachment: rpm54.diff​ added

Run glibtoolize in pre-configure instead of post-patch. Fixes builds in trace mode.

comment:1 Changed 10 years ago by Ionic (Mihai Moldovan)

Description: modified (diff)

comment:2 Changed 10 years ago by Ionic (Mihai Moldovan)

Resolution: → fixed
Status: new → closed

r135230 removed the glibtoolize call, as it was unneeded anyway.

Thanks to afb for working with me on that.

Note: See TracTickets for help on using tickets.