textmate2: build failed: error: thread-local storage i s not supported for the current target

[lpsinger (Leo Singer)]

textmate2 build fails with the following error message:

:info:configure Frameworks/crash/src/info.cc:61:3: error: thread-local storage i
s not supported for the current target
:info:configure                 thread_local stack_t stack;
:info:configure                 ^
:info:configure Frameworks/crash/src/info.cc:62:10: warning: reference to stack 
memory associated with local variable 'stack' returned [-Wreturn-stack-address]
:info:configure                 return stack;
:info:configure                        ^~~~~
:info:configure 1 warning and 1 error generated.

The full build log is attached.

[lpsinger (Leo Singer)]

Build log

[neverpanic (Clemens Lang)]

Yes. This is a bug in Apple's clang, which apparently never supported this feature, but did not correctly error out when it was used until recently. Now that Apple has added this check, compilation fails.

We should write a patch that replaces the thread_local specifier with pthread's methods to get thread-local memory instead for now.

[neverpanic (Clemens Lang)]

Actually, upstream already has this fixed, so I backported the fix and also updated to the latest version (because that has also been blocked by the same problem) in r136712.