Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#47887 closed submission (fixed)

cantera-devel: New subport of cantera

Reported by: macports@… Owned by: larryv (Lawrence Velázquez)
Priority: Normal Milestone:
Component: ports Version: 2.3.3
Keywords: Cc:
Port: cantera-devel

Description

portfile for the latest published beta version of cantera.

Essentially, only version number and checksums are different from the original cantera portfile. The option 'python_old', which is unsupported in cantera 2.2, is removed.

I will create a patch for the stable cantera port which declares a conflict with cantera-devel as soon as cantera-devel is accepted.

Attachments (2)

Portfile (2.7 KB) - added by macports@… 9 years ago.
Portfile cantera-devel
Portfile-cantera.diff (2.0 KB) - added by macports@… 9 years ago.
Portfile-cantera.diff

Download all attachments as: .zip

Change History (8)

Changed 9 years ago by macports@…

Attachment: Portfile added

Portfile cantera-devel

comment:1 Changed 9 years ago by larryv (Lawrence Velázquez)

If the portfiles are almost identical, maybe you should implement cantera-devel as a subport of cantera. See the tmux portfile for an example.

comment:2 Changed 9 years ago by macports@…

Yes, this would be a much better way. Thank you for the hint, I didn't know about the subport feature. I'll create a new ticket for the improvement in the cantera port. Please close this ticket.

comment:3 in reply to:  2 Changed 9 years ago by larryv (Lawrence Velázquez)

Owner: changed from macports-tickets@… to larryv@…
Status: newassigned
Summary: New port cantera-develcantera-devel: New subport of cantera

It’s fine, we can keep using this ticket.

comment:4 Changed 9 years ago by macports@…

OK, I added a patch for the main cantera port which includes cantera-devel as a subport. Everything is quite straigt-forward, except that I had to remove the line github.tarball_from releases from the original port. However, I don't know why this line got there in the first place, and what its advantage is. The original cantera port builds fine also without that line.

Changed 9 years ago by macports@…

Attachment: Portfile-cantera.diff added

Portfile-cantera.diff

comment:5 Changed 9 years ago by macports@…

Hi, as cantera 2.2.0 was recently released, I changed the diff to also include the new version.

comment:6 in reply to:  4 Changed 9 years ago by larryv (Lawrence Velázquez)

Resolution: fixed
Status: assignedclosed

Replying to macports@…:

OK, I added a patch for the main cantera port which includes cantera-devel as a subport.

Thanks, but I had to redo the patch. Since the github.setup proc sets several portfile options, it needs to be called near the beginning. Otherwise it overrides the settings from the rest of the portfile.

r137350 and r137351

Everything is quite straigt-forward, except that I had to remove the line github.tarball_from releases from the original port. However, I don't know why this line got there in the first place, and what its advantage is. The original cantera port builds fine also without that line.

It changes the location from which MacPorts fetches the source code:

These files usually don’t have the same contents, but they might. It depends on the project. Feel free to ask on macports-dev if you have more questions.

Last edited 9 years ago by larryv (Lawrence Velázquez) (previous) (diff)
Note: See TracTickets for help on using tickets.