#47887 closed submission (fixed)
cantera-devel: New subport of cantera
Reported by: | macports@… | Owned by: | larryv (Lawrence Velázquez) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 2.3.3 |
Keywords: | Cc: | ||
Port: | cantera-devel |
Description
portfile for the latest published beta version of cantera.
Essentially, only version number and checksums are different from the original cantera portfile. The option 'python_old', which is unsupported in cantera 2.2, is removed.
I will create a patch for the stable cantera port which declares a conflict with cantera-devel as soon as cantera-devel is accepted.
Attachments (2)
Change History (8)
Changed 9 years ago by macports@…
comment:1 Changed 9 years ago by larryv (Lawrence Velázquez)
If the portfiles are almost identical, maybe you should implement cantera-devel
as a subport of cantera
. See the tmux
portfile for an example.
comment:2 follow-up: 3 Changed 9 years ago by macports@…
Yes, this would be a much better way. Thank you for the hint, I didn't know about the subport feature. I'll create a new ticket for the improvement in the cantera port. Please close this ticket.
comment:3 Changed 9 years ago by larryv (Lawrence Velázquez)
Owner: | changed from macports-tickets@… to larryv@… |
---|---|
Status: | new → assigned |
Summary: | New port cantera-devel → cantera-devel: New subport of cantera |
It’s fine, we can keep using this ticket.
comment:4 follow-up: 6 Changed 9 years ago by macports@…
OK, I added a patch for the main cantera port which includes cantera-devel as a subport.
Everything is quite straigt-forward, except that I had to remove the line github.tarball_from releases
from the original port. However, I don't know why this line got there in the first place, and what its advantage is. The original cantera port builds fine also without that line.
comment:5 Changed 9 years ago by macports@…
Hi, as cantera 2.2.0 was recently released, I changed the diff to also include the new version.
comment:6 Changed 9 years ago by larryv (Lawrence Velázquez)
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Replying to macports@…:
OK, I added a patch for the main cantera port which includes cantera-devel as a subport.
Thanks, but I had to redo the patch. Since the github.setup
proc sets several portfile options, it needs to be called near the beginning. Otherwise it overrides the settings from the rest of the portfile.
Everything is quite straigt-forward, except that I had to remove the line
github.tarball_from releases
from the original port. However, I don't know why this line got there in the first place, and what its advantage is. The original cantera port builds fine also without that line.
It changes the location from which MacPorts fetches the source code:
github.tarball_from tags
(default): https://github.com/Cantera/cantera/archive/v2.2.0.tar.gzgithub.tarball_from releases
: https://github.com/Cantera/cantera/releases/download/v2.2.0/cantera-2.2.0.tar.gz
These files usually don’t have the same contents, but they might. It depends on the project. Feel free to ask on macports-dev if you have more questions.
Portfile cantera-devel