Submission: New port: py-triangle

[smithsp (Sterling Smith)]

Adds a port for the python bindings to the triangle library.

[mf2k (Frank Schima)]

Thanks. Some comments:

• The depends_lib-append line needs to go inside the if {$subport != $name} block.
• Can we also add openmaintainer?

[petrrr]

Cc Me!

[mojca (Mojca Miklavec)]

• If you use the GitHub PortGroup, you don't need the pypi master site.
  • Except that ​https://github.com/drufat/triangle/releases lists different versions than pypi (version 2015.03.28 is not available at all).
• No need for python versions 26 32 33, those are phased out, it's better to use 27 34 35 only (36 is not yet ready).
• No need for md5
• There is a minor whitespace inconsistency inside the block.

[mojca (Mojca Miklavec)]

More important though: the triangle dependency could use some cleanup and needs a maintainer as well. It fetches

/opt/local/var/macports/distfiles/triangle/triangle.zip

instead of using at least some version number somewhere (then again this probably doesn't need a change before some update comes up). It also needs some whitespace cleanup.

[smithsp (Sterling Smith)]

I appreciate the review. You will need to be more specific about the whitespace problems of this Portfile. I do not intend to change the triangle Portfile.

[smithsp (Sterling Smith)]

Revised portfile for python versions, remove pypi, and possible whitespace error

[mojca (Mojca Miklavec)]

Just curious: why did you completely drop python 3 now?

One thing that confuses me is the mixture of pypi and github. The whole idea of the github portgroup is mostly to fetch the sources from GitHub, but in that case there's no need to fetch anything from pypi. If you fetch from pypi, there's no need for the github portgroup. My (personal!!!) preference is to use GitHub (unless the generated files are missing), but the versions available in GitHub are different in this case. I would also like to make one thing clear: this ticket is pretty old (it went unnoticed for a long time until you asked on the mailing list). Is the version 2015.03.28 still the one you want to use? I see version 2016-something being available, but pypi says the latest one is a beta, so it's not entirely clear what's desired.

[mojca (Mojca Miklavec)]

Cc Me!

[smithsp (Sterling Smith)]

I dropped python3 because I have not tested it with python3.

I know that the ticket is old. I'm perfectly happy with the version I am requesting in the Portfile even though it is not the most up to date version, because I have used it in the past, and then I don't have to test the newer version. I have listed myself as a maintainer, and I would be happy to try out a newer version when another user requests it.

I mixed the github and python groups because it is perfectly reasonable that a python project be hosted on GitHub (the github group is used for more than just downloading sources).

[raimue (Rainer Müller)]

Pull Request: ​https://github.com/macports/macports-ports/pull/45

[smithsp (Sterling Smith)]

In 643f5091/macports-ports:

py-triangle: New port

Fixes: #47941