Opened 9 years ago

Closed 9 years ago

#48192 closed update (fixed)

libass: update to 0.12.2, port to GitHub

Reported by: Ionic (Mihai Moldovan) Owned by: coax@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc:
Port: libass

Description

libass has seen newer versions for a while, but the port is currently stale at version 0.10.2.

Furthermore, the project switched to GitHub some time ago.

It is openmaintainer, but due to the changed being quite substantial, I'm not committing without asking the maintainer first.

Attachments (1)

libass.patch (2.4 KB) - added by Ionic (Mihai Moldovan) 9 years ago.
Update libass to 0.12.2, port to GitHub. Updated to work universally.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 9 years ago by Ionic (Mihai Moldovan)

Good thing I slept over it.

While waking up, I realized that the ASM parts will probably not work on ppc(64), so the port be broken for ppc(64) users.

Even worse, it turned out even i386 didn't compile correctly.

The new patch version fixes these problems (although I have only tested building on i386 and x86_64.)

Changed 9 years ago by Ionic (Mihai Moldovan)

Attachment: libass.patch added

Update libass to 0.12.2, port to GitHub. Updated to work universally.

comment:2 Changed 9 years ago by larryv (Lawrence Velázquez)

+    if {[string match "*i386*" ${configure.universal_archs}] ||
+        [string match "*x86_64*" ${configure.universal_archs}]} {
+        depends_build-append port:yasm
+    }

You should use this instead:

if {"i386" in ${configure.universal_archs} || "x86_64" in ${configure.universal_archs}}

comment:3 Changed 9 years ago by Ionic (Mihai Moldovan)

Are you sure that works? vim's syntax highlighting doesn't like it.

comment:4 in reply to:  3 Changed 9 years ago by larryv (Lawrence Velázquez)

Vim’s Tcl highlighting is mediocre at best. I tend to ignore it.

[titan] 92134 % rlwrap port-tclsh
% set foo {x86_64 ppc64}
x86_64 ppc64
% expr {"x86_64" in $foo}
1
% expr {"i386" in $foo}
0

comment:5 Changed 9 years ago by Ionic (Mihai Moldovan)

Maintainer timeout. Pushed in r138214.

comment:6 Changed 9 years ago by Ionic (Mihai Moldovan)

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.