Opened 9 years ago
Closed 9 years ago
#48390 closed enhancement (fixed)
auto-multiple-choice @1.2.1 prepare for Perl 5.22 migration
| Reported by: | nortcele | Owned by: | Ionic (Mihai Moldovan) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | haspatch maintainer | Cc: | |
| Port: | auto-multiple-choice |
Description
A patch to ease migration of auto-multiple-choice to Perl 5.22. (For now the migration doesn't work see ticket #47015).
Attachments (4)
Change History (17)
comment:1 Changed 9 years ago by mf2k (Frank Schima)
| Priority: | High → Normal |
|---|
comment:2 Changed 9 years ago by nortcele
comment:3 Changed 9 years ago by mf2k (Frank Schima)
| Keywords: | haspatch maintainer added |
|---|---|
| Version: | 2.3.3 |
Thanks!
comment:4 Changed 9 years ago by nortcele
Changed patches to ask Perl for vendorlib path instead of trying to construct it.
comment:5 Changed 9 years ago by Ionic (Mihai Moldovan)
| Owner: | changed from macports-tickets@… to ionic@… |
|---|---|
| Status: | new → assigned |
Wouldn't it be a lot easier to just use the perl5 PortGroup, set perl5.branches and reset perl5.link_binaries_suffix like the ack port does?
You could then simply use ${perl5.lib} for the VENDORLIB thingy.
Changed 9 years ago by nortcele
| Attachment: | patch-makefile-macports.conf.p5.22.diff added |
|---|
Patch not needed. Don't know how to delete a ticket file.
Changed 9 years ago by nortcele
| Attachment: | auto-multiple-choice-1.2.1-r4.2.2.diff added |
|---|
Patch not needed. Don't know how to delete a ticket file.
comment:7 Changed 9 years ago by nortcele
comment:8 Changed 9 years ago by nortcele
I forgot to mention that these modifications work even with P5.16 as default perl.
comment:9 Changed 9 years ago by Ionic (Mihai Moldovan)
The problem is... that I don't like that. Not because it's wrong as such, but because it's duplicating code already existing in the perl5 PortGroup.
Can't we just use that? I will look into the PortGroup more intensively to find out if pure applications would be affected. I know the python PortGroup handles things differently for modules vs. applications - perl5 shouldn't be any exception.
Changed 9 years ago by nortcele
| Attachment: | auto-multiple-choice-1.2.1-r4.1.diff added |
|---|
Patch to easy change of perl version.
Changed 9 years ago by nortcele
| Attachment: | auto-multiple-choice-1.2.1-r4.2.diff added |
|---|
Patch to adapt library path to perl 5.22
comment:11 Changed 9 years ago by Ionic (Mihai Moldovan)
Looks way better! One comment: when committing, I'll drop the perl5.major guard. If using the PortGroup, this variable will always be set.
Just ACK or NAK this in a comment here, you don't need to update the patches. I'll do that on the fly.
comment:13 Changed 9 years ago by Ionic (Mihai Moldovan)
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Patch 1 applied as r140543 with the announced changes. Also, I've added a revbump just to be safe because the commit also changes the way the port is being built.
r140544 contains a whitespace-only change I have only noticed in my editor. There was a line containing spaces only.
Patch 2 with slight modification to the revision change (4 instead of 3 due to the previous revbump) applied as r140545.
Thanks for your work and patience!
Added a patch file to make the application library saved in the perl 5.2 hierarchy, and to adapt the portfile to perl 5.22. The application could only work when perl 5.22 is the default Macports version.