#48551 closed enhancement (fixed)
Update par to include support for UTF-8
| Reported by: | casr+macports@… | Owned by: | qbarnes (Quentin Barnes) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | haspatch | Cc: | mimaoffice (Michele Marcionelli) |
| Port: | par |
Description
Patches on the author's website include support for UTF-8. I've cleaned them up a bit so that it applies cleanly for the Macports version.
Attachments (1)
Change History (14)
comment:1 follow-up: 12 Changed 9 years ago by mf2k (Frank Schima)
| Cc: | qbarnes@… removed |
|---|---|
| Keywords: | haspatch added; i18n multibyte utf-8 par removed |
| Owner: | changed from macports-tickets@… to qbarnes@… |
| Version: | 2.3.3 |
comment:2 Changed 9 years ago by qbarnes (Quentin Barnes)
The basic idea of the patch seems fine. A couple of comments though.
The description string in the Portfile doesn't have {...} around it (i.e. "{adds support for multibyte characters}"). Could this cause problems at some point?
This patch assumes ticket 47231 hasn't been integrated. If this one is integrated before 47231, it'll conflict and break 47231's patch. If this one is integrated after 47231, its patch will break.
comment:3 Changed 9 years ago by qbarnes (Quentin Barnes)
One more thing. I recall that we weren't supposed to submit patches of patches (like was done here), but poking around, I can't find that directive anymore. Did that change or am I just not finding it anymore?
comment:4 Changed 9 years ago by mf2k (Frank Schima)
The patch is fine as is. Basically either patch the entire port directory like was done by casr or supply a Portfile patch with new patchfiles.
All patches are based on the current svn revision and thus should not rely on submitted patches. This is the reason we prefer a patchfile because the change from #47231 can be easily applied to a modified Portfile.
The description field should basically never need to use brackets.
comment:5 Changed 9 years ago by qbarnes (Quentin Barnes)
The patch then looks good. Please check it in when you can. It'll need to be redone or hand-done given 47231 has been now checked in.
comment:6 Changed 9 years ago by casr+macports@…
Don't be too alarmed by the big diff on Portfile – I changed the Portfile to remove tabs in favour of spaces to reflect "best practice" from https://guide.macports.org/#development.practices.portstyle
comment:7 Changed 9 years ago by mf2k (Frank Schima)
Please add the license.
$ port lint --nitpick ---> Verifying Portfile for par Warning: no license set ---> 0 errors and 1 warnings found.
comment:8 follow-up: 9 Changed 9 years ago by qbarnes (Quentin Barnes)
The patch looks fine. Good to know about the new "style" on tabs. Please commit.
As for the license, the author of par has never specified a license that I am aware of.
comment:9 Changed 9 years ago by casr+macports@…
Replying to qbarnes@…:
As for the license, the author of par has never specified a license that I am aware of.
This is what I thought as well so I contacted the author over email. He had specified it in a slightly unusual place and he's now pointed me in the right direction.
From http://www.nicemice.net/par/par-doc.var :
Rights and Responsibilities
The files listed in the Files List section above are each Copyright 2001 by Adam M. Costello (henceforth "I", "me").
I grant everyone ("you") permission to do whatever you like with these files, provided that if you modify them you take reasonable steps to avoid confusing or misleading people about who wrote the modified files (both you and I) or what version they are. All official versions of Par will have version numbers consisting of only digits and periods.
I encourage you to send me copies of your modifications in case I wish to incorporate them into future versions of Par. See the Bugs section for my address.
Though I have tried to make sure that Par is free of bugs, I make no guarantees about its soundness. Therefore, I am not responsible for any damage resulting from the use of these files.
I do not know how to specify such a licence within the realm of Macports, however...
comment:10 Changed 9 years ago by qbarnes (Quentin Barnes)
The license update looks good to me. Check it in (assuming its description meets the criteria of macports).
I was going to say that his license sounds the closest to WTFPL (https://en.wikipedia.org/wiki/WTFPL). :-)
comment:11 Changed 9 years ago by mimaoffice (Michele Marcionelli)
| Cc: | michele.marcionelli@… added |
|---|
Cc Me!
comment:12 Changed 9 years ago by casr+macports@…
I think this patch is all ready to be merged when someone gets a chance.
comment:13 Changed 9 years ago by mf2k (Frank Schima)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Sorry for the delay. Some more notes:
- Please use rmd160 and sha256 checksums.
md5is obsolete and should only be included if provided upstream. - The new spacing actually does not conform to the mode line. Please use increments of 4 spaces (i.e. add one more space in most lines).
- There are a few tabs remaining.
I made the fixes and committed this in r143643.
Thanks!