Opened 9 years ago
Last modified 9 years ago
#48562 new update
Update qwt to 6.1.2
Reported by: | ghweber@… | Owned by: | macports-tickets@… |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 2.3.3 |
Keywords: | haspatch | Cc: | kurthindenburg (Kurt Hindenburg), michaelld (Michael Dickens) |
Port: | qwt |
Description
Hi,
The attached Portfile adds a qwt61 variant (replacing the qwt-devel variant that installs an outdated release 6.1 release candidate), which installs the current Qwt 6.1.2
The following changes are necessary:
- Update Portfile according to attached patch
- Remove: files/patch-designer_designer.pro.610rc3.diff files/patch-qwtbuild.pri.610rc3.diff files/patch-qwtconfig.pri.610rc3.diff files/patch-qwtfunctions.pri.610rc3.diff
- Add attached: files/patch-designer_designer.pro.61.diff files/patch-qwtbuild.pri.61.diff files/patch-qwtconfig.pri.61.diff
A few comments:
- When trying to update patch-qwtfunctions.pri.61.diff from the old release candidate build, linking failed. Omitting the patch seems to do the right thing.
- I am not sure if I need to add something to ensure that existing installations of qwt-devel get upgraded to qwt61.
- If I am not mistaken, the variants "debug" and "examples" do not do anything and could be removed.
Gunther
Attachments (7)
Change History (12)
Changed 9 years ago by ghweber@…
Attachment: | Portfile.patch added |
---|
Changed 9 years ago by ghweber@…
Attachment: | patch-designer_designer.pro.61.diff added |
---|
Changed 9 years ago by ghweber@…
Attachment: | patch-qwtbuild.pri.61.diff added |
---|
Changed 9 years ago by ghweber@…
Attachment: | patch-qwtconfig.pri.61.diff added |
---|
comment:1 follow-up: 2 Changed 9 years ago by ryandesign (Ryan Carsten Schmidt)
comment:2 Changed 9 years ago by ghweber@…
Replying to ryandesign@…:
Replying to ghweber@…:
The attached Portfile adds a qwt61 variant (replacing the qwt-devel variant that installs an outdated release 6.1 release candidate), which installs the current Qwt 6.1.2
You mean subport, not variant.
Yes, I did.
- I am not sure if I need to add something to ensure that existing installations of qwt-devel get upgraded to qwt61.
Yes, you do: you need to retain a qwt-devel subport, which contains the line
replaced_by qwt61
. The version or revision of qwt-devel also needs to be increased to cause the replacement to occur. See https://guide.macports.org/chunked/development.practices.html#development.practices.rename-replace-port
I tried to modify the Portfile accordingly. However, I cannot figure out how to make this work properly with subports. I am attaching a diff and the Portfile for my attempt. When I try to install qwt-develp, it still tries to download the distfiles (even though I have an empty distfiles line as indicated in the instruction) and does not print the error message listed in pre-configure.
How do I make this work with a subport?
Gunther
Changed 9 years ago by ghweber@…
Attachment: | Portfile.2.patch added |
---|
Changed 9 years ago by ghweber@…
Changed 9 years ago by kurthindenburg (Kurt Hindenburg)
Attachment: | qwt-61.diff added |
---|
Add qwt61 subport
comment:4 Changed 9 years ago by kurthindenburg (Kurt Hindenburg)
Cc: | michaelld@… added |
---|
I've attached my attempt at adding qwt61 - note that this won't build now due to recent Qt issues - see ticket 49143
comment:5 Changed 9 years ago by kurthindenburg (Kurt Hindenburg)
Michael, it looks you've committed most/all of this - can this ticket be closed?
Replying to ghweber@…:
You mean subport, not variant.
Yes, you do: you need to retain a qwt-devel subport, which contains the line
replaced_by qwt61
. The version or revision of qwt-devel also needs to be increased to cause the replacement to occur. See https://guide.macports.org/chunked/development.practices.html#development.practices.rename-replace-port