#48686 closed submission (fixed)
[pugixml][1.6][new]
| Reported by: | nikkoara@… | Owned by: | macports-tickets@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.3.3 |
| Keywords: | Cc: | help@…, ryandesign (Ryan Carsten Schmidt), krissen (Kristian Niemi) | |
| Port: | pugixml |
Description
Basic Portfile for pugixml.
Attachments (3)
Change History (17)
Changed 9 years ago by nikkoara@…
comment:1 follow-ups: 2 3 Changed 9 years ago by ryandesign (Ryan Carsten Schmidt)
comment:2 follow-up: 9 Changed 9 years ago by nikkoara@…
Replying to ryandesign@…:
The github portgroup should be used.
There is a line there that indicates the github portgroup. If there is something else that you want me to add, could you please be more specific?
The revision line should be removed.
Done. Thanks!
comment:3 Changed 9 years ago by nikkoara@…
Replying to ryandesign@…:
Thanks.
The github portgroup should be used.
The revision line should be removed
Any updates? Thanks.
comment:5 follow-up: 6 Changed 9 years ago by help@…
Portfile.2 works fine for me, please add this port.
comment:6 Changed 9 years ago by nikkoara@…
Replying to help@…:
Portfile.2 works fine for me, please add this port.
Guys, I am not sure if you're waiting for me to do something about it. If so, please let me know, explicitly. Otherwise, I am eagerly waiting for this to become part of the official ports. Thanks.
comment:7 Changed 9 years ago by mf2k (Frank Schima)
Some more comments:
- The distfiles line should be removed because that is the default.
- An rmd160 checksum should be added.
- openmaintainer should be added.
comment:8 Changed 9 years ago by mojca (Mojca Miklavec)
The first line is probably a matter of github.setup, right? (I didn't try it.)
I would also suggest adding
cmake.out_of_source yes
as mentioned in the ticket #47197. That is not an obligatory part, but something that would be helpful for the future.
comment:9 Changed 9 years ago by ryandesign (Ryan Carsten Schmidt)
Replying to nikkoara@…:
Replying to ryandesign@…:
The github portgroup should be used.
There is a line there that indicates the github portgroup. If there is something else that you want me to add, could you please be more specific?
You have included the github portgroup, but are not using it. For instructions on how to use it, read its source code.
comment:11 Changed 9 years ago by nikkoara@…
Thanks for all feed-back. I think I have addressed them all and I have attached the updated Portfile.
comment:12 Changed 9 years ago by raimue (Rainer Müller)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Thanks, this looks good now. I made another slight change by swapping the maintainer names. Real persons should be listed before openmaintainer.
Committed in r142578.
comment:13 Changed 9 years ago by ryandesign (Ryan Carsten Schmidt)
Removed "universal_variant yes" in r142601 because that is the default.
Thanks.
The github portgroup should be used.
The revision line should be removed.