update mosh to 1.2.5

[bket]

Included a diff for updating mosh to the latest version (1.2.5).

[quentinmit (Quentin Smith)]

LGTM. Unfortunately I can't add haspatch to this ticket; perhaps you can add that? (in the Keywords field)

[bket]

Replying to quentin@…:

LGTM. Unfortunately I can't add haspatch to this ticket; perhaps you can add that? (in the Keywords field)

Nope...I'm unable to edit details in the ticket. Only thing I can do is add a new comment. I guess this keyword is used to draw attention from someone who has commit rights?

[neverpanic (Clemens Lang)]

I can commit this. Note that we're also moving our default perl version to 5.22 (see #48365). Do you want me to fix this along the way as well?

[neverpanic (Clemens Lang)]

Committed in r140016 without the perl change -- we can do that in a follow-up.

[quentinmit (Quentin Smith)]

Whoops. I was just about to say "I just tested with perl 5.22 and that works fine". I guess I should file a new ticket with the patch for the perl change?

[neverpanic (Clemens Lang)]

I'll just do it inline here, just a sec.

[neverpanic (Clemens Lang)]

Portfile

@@ -5 +5 @@
 
 name                    mosh
 version                 1.2.5
+revision                1
 categories              net
 license                 {GPL-3+ OpenSSLException}
 platforms               darwin
@@ -25 +26 @@
                         port:protobuf-cpp \
                         port:zlib \
                         path:lib/libssl.dylib:openssl \
-                        port:p5.16-getopt-long
+                        port:p5.22-getopt-long \
+                        port:p5.22-io-socket-ip
 
 post-patch {
-    reinplace "s|#!/usr/bin/env perl|#!${prefix}/bin/perl5.16|" ${worksrcpath}/scripts/mosh.pl
+    reinplace "s|#!/usr/bin/env perl|#!${prefix}/bin/perl5.22|" ${worksrcpath}/scripts/mosh.pl
 }
 
 post-destroot {

OK to commit?

[quentinmit (Quentin Smith)]

Yep, looks good. I just tested that and it seems to work correctly.

[neverpanic (Clemens Lang)]

Committed in r140028, thank you for your time.