Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#48765 closed update (fixed)

update mosh to 1.2.5

Reported by: bket Owned by: quentinmit (Quentin Smith)
Priority: Normal Milestone:
Component: ports Version: 2.3.3
Keywords: haspatch Cc:
Port: mosh

Description

Included a diff for updating mosh to the latest version (1.2.5).

Attachments (1)

mosh.diff (1.5 KB) - added by bket 9 years ago.

Download all attachments as: .zip

Change History (12)

Changed 9 years ago by bket

Attachment: mosh.diff added

comment:1 Changed 9 years ago by petrrr

Cc: quentin@… removed
Owner: changed from macports-tickets@… to quentin@…

comment:2 Changed 9 years ago by quentinmit (Quentin Smith)

LGTM. Unfortunately I can't add haspatch to this ticket; perhaps you can add that? (in the Keywords field)

comment:3 in reply to:  2 Changed 9 years ago by bket

Replying to quentin@…:

LGTM. Unfortunately I can't add haspatch to this ticket; perhaps you can add that? (in the Keywords field)

Nope...I'm unable to edit details in the ticket. Only thing I can do is add a new comment. I guess this keyword is used to draw attention from someone who has commit rights?

comment:4 Changed 9 years ago by neverpanic (Clemens Lang)

Keywords: haspatch added

comment:5 Changed 9 years ago by neverpanic (Clemens Lang)

I can commit this. Note that we're also moving our default perl version to 5.22 (see #48365). Do you want me to fix this along the way as well?

comment:6 Changed 9 years ago by neverpanic (Clemens Lang)

Resolution: fixed
Status: newclosed

Committed in r140016 without the perl change -- we can do that in a follow-up.

comment:7 Changed 9 years ago by quentinmit (Quentin Smith)

Whoops. I was just about to say "I just tested with perl 5.22 and that works fine". I guess I should file a new ticket with the patch for the perl change?

comment:8 Changed 9 years ago by neverpanic (Clemens Lang)

I'll just do it inline here, just a sec.

comment:9 Changed 9 years ago by neverpanic (Clemens Lang)

Index: Portfile
===================================================================
--- Portfile	(revision 140016)
+++ Portfile	(working copy)
@@ -5,6 +5,7 @@
 
 name                    mosh
 version                 1.2.5
+revision                1
 categories              net
 license                 {GPL-3+ OpenSSLException}
 platforms               darwin
@@ -25,10 +26,11 @@
                         port:protobuf-cpp \
                         port:zlib \
                         path:lib/libssl.dylib:openssl \
-                        port:p5.16-getopt-long
+                        port:p5.22-getopt-long \
+                        port:p5.22-io-socket-ip
 
 post-patch {
-    reinplace "s|#!/usr/bin/env perl|#!${prefix}/bin/perl5.16|" ${worksrcpath}/scripts/mosh.pl
+    reinplace "s|#!/usr/bin/env perl|#!${prefix}/bin/perl5.22|" ${worksrcpath}/scripts/mosh.pl
 }
 
 post-destroot {

OK to commit?

Version 2, edited 9 years ago by neverpanic (Clemens Lang) (previous) (next) (diff)

comment:10 Changed 9 years ago by quentinmit (Quentin Smith)

Yep, looks good. I just tested that and it seems to work correctly.

comment:11 Changed 9 years ago by neverpanic (Clemens Lang)

Committed in r140028, thank you for your time.

Note: See TracTickets for help on using tickets.