#48873 closed defect (fixed)
ipe fails to build with new lua 5.3
Reported by: | m7.thon@… | Owned by: | ryandesign (Ryan Carsten Schmidt) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 2.3.3 |
Keywords: | haspatch maintainer | Cc: | Limbo999 (Franziska Wegner) |
Port: | ipe |
Description
ipe requires lua 5.2 and is not currently compatible with lua 5.3. Unfortunately, the lua port has been updated from 5.2 to 5.3, breaking ipe.
A port "lua52" is required to fix this.
Attachments (2)
Change History (14)
comment:2 Changed 9 years ago by m7.thon@…
Ok, so this now makes ipe compile with lua 5.3 (and also lua 5.2)
This only required replacing "luaL_checkint" and "luaL_optlong" by "(int)luaL_checkinteger" and "(long)luaL_optinteger", which used to be defined like this by macros, so I do not expect any problems (it seems to run fine from brief testing).
I'll submit the patch upstream as well, but it may take a while for the new version to appear.
Could someone please commit (I maintain the ipe port, but have no commit rights)? Thanks.
comment:3 Changed 9 years ago by mf2k (Frank Schima)
Keywords: | haspatch maintainer added |
---|---|
Port: | ipe added |
comment:4 Changed 9 years ago by m7.thon@…
- New simplified Portfile to allow compilation with lua 5.3
- patch-lua53-compatibility.diff no longer needed
I just realized that it is sufficient to compile with lua 5.2 compatibility mode by defining LUA_COMPAT_5_2
(didn't know that this needed to be explicitly enabled)
comment:5 Changed 9 years ago by ryandesign (Ryan Carsten Schmidt)
Cc: | franziska.wegner@… added |
---|---|
Owner: | changed from macports-tickets@… to ryandesign@… |
Status: | new → assigned |
Has duplicate #49085.
comment:6 Changed 9 years ago by ryandesign (Ryan Carsten Schmidt)
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
comment:7 Changed 9 years ago by esperet
I have the same issue as #49085, which was marked as a duplicate of this ticket. It seems that our problem is still unresolved and this ticket should probably not me marked as "fixed", should it? Or maybe the modification sugested in comment 4 hasn't been commited yet?
comment:8 Changed 9 years ago by Limbo999 (Franziska Wegner)
The patch above worked fine for me. There are currently two bugs while installing ipe. You have to install two patches before do so:
- qt4 patch can be downloaded here: qt4-mac.10.11.diff (Ticket #48129)
- Lua 5.3 patch can be downloaded here: Portfile-ipe.diff ( Ticket #48873)
To submit the patches enter the following commands, but replace PATH_TO (for me it was “~/Downloads/” ):
cd $(port dir qt4-mac) sudo patch -p0 < PATH_TO/qt4-mac.10.11.diff cd $(port dir ipe) sudo patch -p0 < PATH_TO/Portfile-ipe.diff
comment:9 Changed 9 years ago by m7.thon@…
@louis:
This patch has been committed, as Ryan has stated above, and this issue should be fixed.
Did you do the following?
sudo port selfupdate sudo port clean ipe sudo port install ipe
You will need to install qt4-mac first (requiring the El Capitan patch that you need to manually apply, as explained above).
comment:10 Changed 9 years ago by esperet
Sorry, I'm confused. The conclusion of Ticket #48129 is that the patch has been commited, so why should I have to apply the El Capitan patch of qt4-mac manually? It is said there that qt4-mac-4.8.7_2 should work fine.
comment:11 follow-up: 12 Changed 9 years ago by m7.thon@…
Yes, you are right. I was not aware that the qt4 patch had been committed. However, qt4 was also reorganized into its own directories to make it no longer conflict with qt5 (another unrelated change), which again breaks ipe. See the new ipe ticket #49192, which has a patch for this as well, but is (as of now) not yet committed.
In any case, this issue (lua 5.3 incompatibility) is fixed.
I added a patch to make ipe compile with lua 5.3. This only replaces instances of "luaL_checkint" by "(int)luaL_checkinteger", so I don't expect any problems. It runs and seems to work fine.
I'll submit the patch upstream as well, but new versions sometimes take a while.
Could someone please commit this for me (am maintainer without commit rights)? Thanks.