Opened 9 years ago
Closed 9 years ago
#48874 closed defect (fixed)
mpv fails to build with lua 5.3
| Reported by: | m7.thon@… | Owned by: | Ionic (Mihai Moldovan) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.3.3 |
| Keywords: | haspatch | Cc: | fracai, grosshei@…, mopihopi |
| Port: | mpv |
Description
mpv fails to build with lua 5.3, and will likely not support lua 5.3 in the near future.
A port "lua52" or similar is required to fix this.
Attachments (1)
Change History (10)
comment:1 Changed 9 years ago by fracai
| Cc: | arno@… added |
|---|
comment:4 Changed 9 years ago by sbutler (Stephen J. Butler)
I created a patch that works for me. Switches to depend on the lua52 port and tells mpv to use the right pkg-config file.
comment:5 Changed 9 years ago by mf2k (Frank Schima)
| Keywords: | haspatch added |
|---|---|
| Owner: | changed from macports-tickets@… to ionic@… |
In the future, please Cc the port maintainers (port info --maintainers mpv), if any.
comment:6 Changed 9 years ago by Ionic (Mihai Moldovan)
Switching to the other port sounds fine.
I cannot tell whether the fbsd is more appropriate off-hand. The last time I checked, it wasn't.
comment:7 Changed 9 years ago by sbutler (Stephen J. Butler)
The lua52 port installs the pkg-config file as "lua-5.2.pc". If you tell mpv to look for "--lua=52" then it tests "lua.pc", whereas if you say "--lua=52fbsd" it looks for "lua-5.2.pc". That's the only difference that I could see.
comment:8 Changed 9 years ago by Ionic (Mihai Moldovan)
Thanks. And that's exactly why the 52fbsd option was not applicable before - the lua port, which was 5.2 before, installed a plain lua.pc file.
I'll preliminarily update the port tomorrow to fix the lua change.
comment:9 Changed 9 years ago by Ionic (Mihai Moldovan)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Pushed fix as r140413. Thanks.
Cc Me!