httping 2.4 no longer has ncurses mode

[breiter (Brian Reiter)]

httping 2.4 is linked against ncurses but it doesn't have a -K option in the resulting binary anymore. I think what has to happen is uncommenting NC=yes and FW=yes in the Makefile or adding those lines to makefile.inc.

Also may want to add TFO=yes.

The configure shell script will set these options. I've attached a patch that enables ncurses mode.

[breiter (Brian Reiter)]

Portfile diff that adds configure script invocation to fix ncurses

[ryandesign (Ryan Carsten Schmidt)]

Thanks.

To use a configure script, we would just remove "use_configure no". We would not add "use_configure yes", because that is the default.

The default value of configure.cmd is "./configure", which is what we would use here. We would add any needed arguments to configure.args. By default MacPorts will also put "--prefix=${prefix}" into configure.pre_args; if that is unsuitable for this configure script, it can be cleared.

This configure script uses mktemp in a way that is not compatible with OS X, which causes error messages to be printed and probably causes the temp files not to be created, which could cause the configure script to function incorrectly. I see you're attempting to redirect stderr to /dev/null, perhaps to hide these errors. I'd prefer to fix the configure script so that is uses mktemp correctly.

Your changes introduced tab characters into the portfile, but you should try to match the existing whitespace of the portfile, which in this case uses spaces. That's our preferred style, and it's also what the modeline of this portfile states.

Probably, the extra library flags being added to LDFLAGS will no longer be needed once the configure script is being used.

[ryandesign (Ryan Carsten Schmidt)]

r140334. In addition to fixing the configure script's usage of mktemp, I made it remember the values of CC, CFLAGS and LDFLAGS, so that most of the custom code in the portfile isn't needed anymore.