Opened 9 years ago

Closed 9 years ago

#48995 closed enhancement (fixed)

bob @ 1.2.2 Version obsolete

Reported by: tiagofrepereira2012 (Tiago Freitas Pereira) Owned by: andre.anjos@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: laurent.el-shafey@…
Port: bob

Description

Hi,

Follow attached a new port file for the port bob@1.2.2. This port is now obsolete and will be replaced by py-bob. The ticket #48994 is open for that.

Could you please replace it?

Thanks in advance

Tiago

Attachments (2)

bob.zip (1.5 KB) - added by tiagofrepereira2012 (Tiago Freitas Pereira) 9 years ago.
Portfile.bob.diff (5.0 KB) - added by tiagofrepereira2012 (Tiago Freitas Pereira) 9 years ago.

Download all attachments as: .zip

Change History (6)

Changed 9 years ago by tiagofrepereira2012 (Tiago Freitas Pereira)

Attachment: bob.zip added

comment:1 Changed 9 years ago by ryandesign (Ryan Carsten Schmidt)

Keywords: haspatch added
Port: bob added

Instead of attaching a zip file containing a complete portfile, please submit a unified diff of the portfile. This makes it easier to review your proposed changes.

You've declared that bob should be replaced by py-bob. This is not correct, because py-bob is a stub port (as are all ports whose names begin with "py-") -- it doesn't install anything. Instead, you should declare that one of py-bob's subports is the replacement port, for example py27-bob.

You're still defining a variable called soversion, though it is never used. It should be removed.

You're declaring a pre-configure block to print an error message. You're also including the obsolete 1.0 portgroup. One of the things that portgroup does for you is to print that error message; you should not manually declare a pre-configure block to do that.

Proper use of the obsolete 1.0 portgroup requires you to declare the "replaced_by ..." line before the "PortGroup obsolete 1.0" line.

When filing a ticket, remember to fill in the Port field, and include the keyword "haspatch" when you are providing the fix for the issue.

Changed 9 years ago by tiagofrepereira2012 (Tiago Freitas Pereira)

Attachment: Portfile.bob.diff added

comment:2 Changed 9 years ago by tiagofrepereira2012 (Tiago Freitas Pereira)

Hi,

Thanks for the comments. I just attached the diff file following your instructions.

Thanks in advance

Tiago

comment:3 Changed 9 years ago by mf2k (Frank Schima)

Cc: laurent.el-shafey@… added; andre.anjos@… removed
Owner: changed from macports-tickets@… to andre.anjos@…
Type: updateenhancement
Version: 2.3.3

comment:4 Changed 9 years ago by dbevans (David B. Evans)

Resolution: fixed
Status: newclosed

Committed with some cleanups in r142986. Correctly updates bob to py27-bob in testing.

Note: See TracTickets for help on using tickets.