Opened 9 years ago
Closed 9 years ago
#49003 closed enhancement (fixed)
libomp should be built for both i386 and x86_64
Reported by: | howarth.at.macports@… | Owned by: | eborisch (Eric A. Borisch) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 2.3.3 |
Keywords: | Cc: | jeremyhu (Jeremy Huddleston Sequoia) | |
Port: | libomp |
Description (last modified by ryandesign (Ryan Carsten Schmidt))
The attached Portfile diff updates libomp to the r248588 to pick up the new lit-based test suite support for running 'check-libomp' as well as appends -DLIBOMP_OSX_ARCHITECTURES="x86_64;i386" to the cmake flags to build the fat libomp supporting both i386 and x86_64 targets.
% file libomp.dylib libomp.dylib: Mach-O universal binary with 2 architectures libomp.dylib (for architecture x86_64): Mach-O 64-bit dynamically linked shared library x86_64 libomp.dylib (for architecture i386): Mach-O dynamically linked shared library i386
Attachments (1)
Change History (6)
Changed 9 years ago by howarth.at.macports@…
Attachment: | Portfile.diff added |
---|
comment:1 Changed 9 years ago by howarth.at.macports@…
Note that the OpenMP3.1_Validation results for 'make ctest' are reasonable using the proposed libomp packaging and clang-3.7. at -m64...
Summary: S Number of tested Open MP constructs: 62 S Number of used tests: 123 S Number of failed tests: 5 S Number of successful tests: 118 S + from this were verified: 114 Normal tests: N Number of failed tests: 2 N + from this fail compilation: 0 N + from this timed out 0 N Number of successful tests: 60 N + from this were verified: 58 Orphaned tests: O Number of failed tests: 3 O + from this fail compilation: 0 O + from this timed out 0 O Number of successful tests: 58 O + from this were verified: 56
and at -m32...
Summary: S Number of tested Open MP constructs: 62 S Number of used tests: 123 S Number of failed tests: 5 S Number of successful tests: 118 S + from this were verified: 113 Normal tests: N Number of failed tests: 2 N + from this fail compilation: 0 N + from this timed out 0 N Number of successful tests: 60 N + from this were verified: 58 Orphaned tests: O Number of failed tests: 3 O + from this fail compilation: 0 O + from this timed out 0 O Number of successful tests: 58 O + from this were verified: 55
comment:2 Changed 9 years ago by ryandesign (Ryan Carsten Schmidt)
Description: | modified (diff) |
---|
Replying to howarth.at.macports@…:
The attached Portfile diff updates libomp to the r248588 to pick up the new lit-based test suite support for running 'check-libomp' as well as appends -DLIBOMP_OSX_ARCHITECTURES="x86_64;i386" to the cmake flags to build the fat libomp supporting both i386 and x86_64 targets.
A port should only build universally if the universal variant is selected. If a universal build is required, that can be enforced by adding the line "default_variants +universal", but that would be somewhat unusual.
comment:3 Changed 9 years ago by ryandesign (Ryan Carsten Schmidt)
Owner: | changed from macports-tickets@… to eborisch@… |
---|
comment:4 Changed 9 years ago by eborisch (Eric A. Borisch)
It should build universal with +universal already. I will look at the rest of this soon.
comment:5 Changed 9 years ago by eborisch (Eric A. Borisch)
Resolution: | → fixed |
---|---|
Status: | new → closed |
Committed new version in r140675. No changes for universal (works with +universal.)
update to lit-based test suite support and build i386/x86_64 fat libomp