Opened 9 years ago

Closed 9 years ago

#49022 closed defect (wontfix)

VLC-devel: build fails with lua 5.3

Reported by: ballen4705 Owned by: RJVB (René Bertin)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: VLC-devel

Description

:info:build demux.c:61:13: error: implicit declaration of function 'luaL_checkint' is invalid in C99 [-Werror,-Wimplicit-function-declaration]

{{{
:info:build     int n = luaL_checkint( L, 1 );
:info:build             ^
:info:build libs/configuration.c:87:46: error: implicit declaration of function 'luaL_checkint' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
:info:build             config_PutInt( p_this, psz_name, luaL_checkint( L, 2 ) );
:info:build                                              ^
:info:build ../../include/vlc_configuration.h:143:60: note: expanded from macro 'config_PutInt'
:info:build #define config_PutInt(a,b,c) config_PutInt(VLC_OBJECT(a),b,c)

}}}

I believe all tools are up to date, OSX Yosemite 10.10.5

Let me know if more details are needed and I will provide them.

Attachments (2)

main.log (2.5 MB) - added by ballen4705 9 years ago.
Main log file
main.2.log (2.5 MB) - added by ballen4705 9 years ago.
mail.log with build.jobs=1

Change History (10)

comment:1 Changed 9 years ago by ryandesign (Ryan Carsten Schmidt)

Owner: changed from macports-tickets@… to rjvbertin@…
Port: VLC added
Summary: VLC build failsVLC @2.1.5: build fails with lua 5.3

Has duplicate #49023.

Presumably an incompatibility with lua 5.3. After we updated lua to 5.3, we found many projects to be incompatible with lua 5.3.

Still, you should attach the main.log file, as usual when reporting a bug.

Changed 9 years ago by ballen4705

Attachment: main.log added

Main log file

comment:2 Changed 9 years ago by ballen4705

Added log file as requested.

comment:3 Changed 9 years ago by RJVB (René Bertin)

Looks like someone will have to bump the VLC version, or incorporate one of the fixes from https://www.google.fr/search?q=vlc+lua+5.3

About attaching main logs: of course it can be useful to have the full thing that shows output from the configuration step and all, but in cases like this it'd be very practical also to have a 2nd one that comes from repeating the failed port command with build.jobs=1. It will outline the failing build command and its errors much more clearly, without interference from other concurrent build commands (7 of them on an octocore).

comment:4 Changed 9 years ago by RJVB (René Bertin)

VLC 2.2.2 should be lua 5.3 compatible from what I understand, VLC 2.2.1 will actually look for lua 5.2 first. I'm testing a patch that makes port:VLC depend on port:lua52, and will submit the result later today.

Or resubmit it, I think I already did that once ...

Changed 9 years ago by ballen4705

Attachment: main.2.log added

mail.log with build.jobs=1

comment:6 Changed 9 years ago by mojca (Mojca Miklavec)

Port: VLC-devel added; VLC removed
Summary: VLC @2.1.5: build fails with lua 5.3VLC-devel: build fails with lua 5.3
Version: 2.3.3

I will be nasty and will "highjack" this thread. VLC builds against lua 5.2 by now (#49051, r146098). But VLC-devel is still broken in the same way and needs the fix to be "backported" from René's version of VLC.

comment:7 Changed 9 years ago by RJVB (René Bertin)

Actually, I think that VLC 2.2.2 is supposed to build with lua 5.3, but that led me to C99 syntax errors. Lua being a rather lightweight dependency I decided to stick with what's been working before (i.e. depend on lua5.2), but if someone wants to have a look at those compile errors that would of course be nice.

comment:8 Changed 9 years ago by dbevans (David B. Evans)

Resolution: wontfix
Status: newclosed

VLC-devel declared obsolete for now replaced by VLC in r148364. See #50697.

Note: See TracTickets for help on using tickets.