#49343 closed update (fixed)
slime: update to 2.15
| Reported by: | ryandesign (Ryan Carsten Schmidt) | Owned by: | easye |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.3.99 |
| Keywords: | haspatch | Cc: | |
| Port: | slime |
Description
This patch updates slime to 2.15. I am not committing it because I have not tested it, as the comment at the top of the portfile says to do, because I don't know what the testing procedure is.
The port gave no explanation for why it was fetching from a git repository, so I changed it to use a github tarball instead, and it built ok for me.
Attachments (1)
Change History (5)
Changed 9 years ago by ryandesign (Ryan Carsten Schmidt)
| Attachment: | slime-2.15.diff added |
|---|
comment:1 Changed 9 years ago by ryandesign (Ryan Carsten Schmidt)
comment:2 follow-up: 4 Changed 9 years ago by easye
Replying to ryandesign@…: […]
The port gave no explanation for why it was fetching from a git repository, so I changed it to use a github tarball instead, and it built ok for me.
Historically, SLIME did not make versioned releases, so pulling from cvs, and later git, was the only way to go.
That is no longer the case, so changing over to using source release artifacts is the way to go.
N.b. as far as I understand things, we still need to increment the epoch field even though we are building to releases.
comment:3 Changed 9 years ago by easye
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Committed (with epoch update) in r141625.
comment:4 Changed 9 years ago by ryandesign (Ryan Carsten Schmidt)
Replying to easieste@…:
N.b. as far as I understand things, we still need to increment the epoch field even though we are building to releases.
The only reason why the epoch would need to be increased is if the MacPorts vercmp procedure sees the new version as older than the old version. For example, if the old version were "20051225" and the new version were "3.5", then the epoch would need to be increased, because otherwise MacPorts would see "3.5" as older than "20051225" (because 3 is less than 20051225) and would not present the port as an outdated port. That's not the case here: MacPorts has no trouble understanding that "2.15" is newer than "2.14" (because 15 is greater than 14), so no epoch increase was necessary. It doesn't hurt anything to increase the epoch in this case, but there was no reason to do so. (Now that it has been increased, it cannot be changed back, because the epoch may never be decreased.)
This patch also has the side effect of fixing the livecheck.