Opened 9 years ago

Closed 9 years ago

#49576 closed defect (fixed)

Fix incorrect checksums in GMTK Portfile

Reported by: rprogers@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch maintainer Cc: mojca (Mojca Miklavec), kurthindenburg (Kurt Hindenburg)
Port: gmtk

Description

Fixes the incorrect checksums in the Portfile and removes the X11 dependency from the Automake file, as noted in comment:24:ticket:46252.

Attachments (2)

Portfile-gmtk.diff (897 bytes) - added by rprogers@… 9 years ago.
Fix incorrect checksums and remove X11 dependency
Portfile-gmtk.2.diff (1019 bytes) - added by rprogers@… 9 years ago.
drops pkgconfig and the patchfile, and corrects the checksums

Download all attachments as: .zip

Change History (9)

Changed 9 years ago by rprogers@…

Attachment: Portfile-gmtk.diff added

Fix incorrect checksums and remove X11 dependency

comment:1 Changed 9 years ago by mf2k (Frank Schima)

Keywords: haspatch maintainer added

comment:2 Changed 9 years ago by mojca (Mojca Miklavec)

Version: 2.3.4

The attached patch makes no sense to me. It differs from what is in trunk at the moment.

comment:3 Changed 9 years ago by mojca (Mojca Miklavec)

Apart from that the distfiles keep changing almost on a daily basis. I now see three different checksums for the same name and version of software:

  • the checksums in trunk
  • the checksums of the current file
  • the checksums that were apparently current at some point which are listed in Portfile-gmtk.diff

This is generally a "forbidden" (or at least highly discouraged) practice and will not work nicely with MacPorts in the future (the port will be constantly broken).

My preference would be to wait with the change until it becomes clear what the strategy for version updates is going to be in the future. Please write to the MacPorts development mailing list for advice.

comment:4 Changed 9 years ago by rprogers@…

Part of the confusion on my part was that the portfile on your trunk doesn't match the portfile we have in the GMTK RCS nor any of the attachments. I assumed that the latest attached portfile from #46252 was what was committed to MacPorts and have been submitting diffs from that. I didn't notice this until I did a port selfupdate just now. I think the portfile should live in only one RCS, and now that it's committed in MacPorts it should probably live in yours rather than GMTK's.

The portfile on your trunk has some changes I wasn't aware of:

depends_build       port:coreutils \
                    port:pkgconfig

The coreutils is probalby fine, but I'd rather drop pkgconfig - it's only used to locate BLAS which not required to build GMTK.

It also has a patchfile to remove the -lX11 from tksrc/Makefile.am. I've already fixed that in GMTK (this was the "second" 1.4.3 release, for which you rightfully scolded me :) so this isn't necessary.

--without-x was also added to configure.args, which I think is probably good.

I apologize for the distfile churn. We're just trying to get the package in acceptable shape - hopefully things will go more smoothly as we get the MacPorts process figured out. Let me try one more time with a diff against your trunk that drops pkgconfig and the patchfile, and corrects the checksums.

Changed 9 years ago by rprogers@…

Attachment: Portfile-gmtk.2.diff added

drops pkgconfig and the patchfile, and corrects the checksums

comment:5 Changed 9 years ago by ryandesign (Ryan Carsten Schmidt)

You are correct that the portfile should live in only one system: ours. MacPorts requires the portfile to be in its repository to function, and it is confusing if another copy is maintained separately elsewhere.

You should never modify a distfile after it's been released. Distfiles should be immutable. If you must make changes, release them under a new version number. Modifying a distfile after release is what we call a stealth update. You must follow that recipe now. Just changing the checksums is not sufficient.

comment:6 Changed 9 years ago by kurthindenburg (Kurt Hindenburg)

Cc: khindenburg@… added

Cc Me!

comment:7 Changed 9 years ago by kurthindenburg (Kurt Hindenburg)

Resolution: fixed
Status: newclosed

done r143036

Note: See TracTickets for help on using tickets.