Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#49627 closed enhancement (fixed)

ffmpeg: Add libsoxr support

Reported by: casr+macports@… Owned by: dbevans (David B. Evans)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: jeremyhu (Jeremy Huddleston Sequoia)
Port: ffmpeg

Description (last modified by ryandesign (Ryan Carsten Schmidt))

Here are two patches but only one should be applied. One just enables libsoxr support on the default build and the other patch has it as a variant. These patches as dependent on #49599 being applied.

libsoxr is the SoX Resampler library which aims to be a high quality resampling library.

Attachments (3)

Portfile.cleanup-description.patch (2.2 KB) - added by casr+macports@… 9 years ago.
Bonus patch to clean up the long_description
Portfile.no-variant.patch (850 bytes) - added by casr+macports@… 9 years ago.
Portfile.with-variant.patch (713 bytes) - added by casr+macports@… 9 years ago.

Download all attachments as: .zip

Change History (7)

Changed 9 years ago by casr+macports@…

Bonus patch to clean up the long_description

comment:1 Changed 9 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: devans@… removed
Description: modified (diff)
Owner: changed from macports-tickets@… to devans@…
Summary: Add libsoxr support for ffmpegffmpeg: Add libsoxr support

Since both of your patches add soxr support to ffmpeg by default, this would change the files that get installed by default. Therefore the port's revision would need to be increased.

Changed 9 years ago by casr+macports@…

Attachment: Portfile.no-variant.patch added

Changed 9 years ago by casr+macports@…

Attachment: Portfile.with-variant.patch added

comment:2 in reply to:  1 Changed 9 years ago by casr+macports@…

Replying to ryandesign@…:

Since both of your patches add soxr support to ffmpeg by default, this would change the files that get installed by default. Therefore the port's revision would need to be increased.

Thank you for the feedback. I've updated the patches accordingly.

comment:3 Changed 9 years ago by dbevans (David B. Evans)

Resolution: fixed
Status: newclosed

Committed no variant version to ffmpeg in r142659, ffmpeg-devel in r142660. Thanks for the patch.

comment:4 Changed 9 years ago by casr+macports@…

I hadn't considered ffmpeg-devel. Thank you for managing those commits!

Note: See TracTickets for help on using tickets.