wine: add +quartz variant

[mikepparson@…]

Patch to Portfile to enable a quartz variant of wine.

[mikepparson@…]

Patch to wine Portfile to enable a +quartz variant.

[ryandesign (Ryan Carsten Schmidt)]

There is no reason to increase the revision when only adding a non-default variant.

If the port is going to offer a choice between x11 and quartz, if should have both variants, and variants should generally add dependencies and configure arguments, not remove them.

This presumably applies to the wine-devel and wine-crossover ports as well?

See #39085. Many, possibly all, of the dependencies you're deleting in this variant might be erroneous to begin with and should just be removed without adding any variants. Testing is needed to discover which dependencies are still needed and which aren't.

[mikepparson@…]

Replying to ryandesign@…:

There is no reason to increase the revision when only adding a non-default variant.

OK, dropped it back to '4'.

If the port is going to offer a choice between x11 and quartz, if should have both variants, and variants should generally add dependencies and configure arguments, not remove them.

OK. I've split it into two ports with +x11 being the default.

This presumably applies to the wine-devel and wine-crossover ports as well?

I'll try the same edits with those ports.

See #39085. Many, possibly all, of the dependencies you're deleting in this variant might be erroneous to begin with and should just be removed without adding any variants. Testing is needed to discover which dependencies are still needed and which aren't.

I removed all the X11 related dependencies as they are provided with XQuartz.

The +x11 variant builds both the X11 and native Mac driver (their word for it, not mine). The +quartz variant doesn't include the X11 bits.

The reason for the non-X11 specific variant is so that there can be other GTK3 +quartz apps installed at the same time. On my system, I use gimp2 and Inkscape with the +quartz variant specified for both. Attempts to install the X11 (default) wine port results in a bunch of ports being inactivated and the pre-reqs for wine being re-compiled with X11 support.

[mikepparson@…]

Take-2 based on suggestions from maintainers

[ryandesign (Ryan Carsten Schmidt)]

Replying to mikepparson@…:

I removed all the X11 related dependencies as they are provided with XQuartz.

...that's not a valid reason for removing dependencies. MacPorts won't use dependencies installed by Xquartz.

[mikepparson@…]

wine Portfile with no X11.

[mikepparson@…]

Replying to ryandesign@…:

Replying to mikepparson@…:

I removed all the X11 related dependencies as they are provided with XQuartz.

...that's not a valid reason for removing dependencies. MacPorts won't use dependencies installed by Xquartz.

Turns out, the X11 bits were being sucked in anyways by the pre-req of gstreamer. I removed it as well as others mentioned in #39085, except the freetype bits.

Still runs notepad++ like a charm.

[macports@…]

Cc Me!

[fredowski]

Cc Me!

[fredowski]

Hi, I also have the problem that I cannot install a quartz application together with wine. I installed pspp-devel with quartz but wine +quartz -x11 does not install because it ends up in a problem for gtk3. See:

DEBUG: Executing org.macports.patch (gtk3)
--->  Applying patches to gtk3
--->  Applying nawk.patch
DEBUG: Environment: 
CC_PRINT_OPTIONS='YES'
CC_PRINT_OPTIONS_FILE='/opt/local/var/macports/build/_opt_local_var_macports_sources_nue.de.rsync.macports.org_macports_release_gnome_gtk3/gtk3/work/.CC_PRINT_OPTIONS'
CPATH='/opt/local/include'
LIBRARY_PATH='/opt/local/lib'
MACOSX_DEPLOYMENT_TARGET='10.11'
DEBUG: Assembled command: 'cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_nue.de.rsync.macports.org_macports_release_gnome_gtk3/gtk3/work/gtk+-3.18.7" && /usr/bin/patch -p0'
DEBUG: Executing command line:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_nue.de.rsync.macports.org_macports_release_gnome_gtk3/gtk3/work/gtk+-3.18.7" && /usr/bin/patch -p0 < '/opt/local/var/macports/sources/nue.de.rsync.macports.org/macports/release/gnome/gtk3/files/nawk.patch'
patching file configure
DEBUG: Privilege de-escalation not attempted as not running as root.
DEBUG: configure phase started at Sun Feb 21 11:09:29 CET 2016
--->  Configuring gtk3
DEBUG: Using compiler 'Xcode Clang'
DEBUG: Executing proc-pre-org.macports.configure-configure-0
DEBUG: Executing proc-pre-org.macports.configure-configure-1
DEBUG: Active variants check for source-type install considers depends_fetch depends_extract depends_lib depends_build depends_run: xz atk pango gdk-pixbuf2 glib2 gobject-introspection mesa libepoxy pkgconfig shared-mime-info hicolor-icon-theme
DEBUG: Executing proc-pre-org.macports.configure-configure-2
Error: org.macports.configure for port gtk3 returned: Either +x11 or +quartz is required
DEBUG: Error code: NONE
DEBUG: Backtrace: Either +x11 or +quartz is required
    while executing
"proc-pre-org.macports.configure-configure-2 org.macports.configure"
    ("eval" body line 1)
    invoked from within
"eval $pre $targetname"
Warning: targets not executed for gtk3: org.macports.activate org.macports.configure org.macports.build org.macports.destroot org.macports.install
Error: Failed to install gtk3
DEBUG: Registry error: libGLU not registered as installed & active.
    invoked from within
"registry_active $subport"
    invoked from within
"$workername eval registry_active \$subport"
Please see the log file for port gtk3 for details:
    /opt/local/var/macports/logs/_opt_local_var_macports_sources_nue.de.rsync.macports.org_macports_release_gnome_gtk3/gtk3/main.log
Error: The following dependencies were not installed: gstreamer010-gst-plugins-base gnome-vfs gconf gtk3 orbit2 libidl policykit mozjs17 autoconf213 nspr gnome-mime-data iso-codes libogg libtheora libvorbis orc lcms2 libGLU
To report a bug, follow the instructions in the guide:
    http://guide.macports.org/#project.tickets
Error: Processing of port wine failed
FriedrisMacBook:~ fritz$ 

If I just do +quartz, then it ends up in a problem for pango, where you have to install either quartz or x11. So it would be nice, if the wine package would at least allow to have other applications to use +quartz.

Friedrich

[ryandesign (Ryan Carsten Schmidt)]

Friedrich, the wine port today does not have any variants, neither quartz nor x11 variants. (This ticket suggests adding them, but this has not been done yet.) So the wine port has nothing to do with the error you received when installing the gtk3 port. The error message you're getting from the gtk3 port—Either +x11 or +quartz is required—is accurate—you must indeed select one or the other—but I have no idea why gtk3 thinks you have selected neither variant, since you said you have selected +quartz. Perhaps you should ask for help on the macports-users list.

[mojca (Mojca Miklavec)]

See also ​https://github.com/macports/macports-ports/pull/374

[Chris Rawnsley <chris@…>]

In df1977479ee137435dbc8a42c48385e6e18dee5a/macports-ports:

wine*: X11 is an optional dependency

Closes: #49800
Closes: #39085