Changes between Initial Version and Version 2 of Ticket #49821


Ignore:
Timestamp:
Nov 26, 2015, 8:20:27 PM (9 years ago)
Author:
ryandesign (Ryan Carsten Schmidt)
Comment:

Replying to hans@…:

(The double underscore fucked up my message.)

I fixed your formatting. Remember to use WikiFormatting and to preview before submitting.

I am leaving src__config.h.ed as is, but I am not completely sure about its purpose; if __BIG_ENDIAN__, __LP64__, etc, is defined, then ./configure (which creates config.h) is supposed to figure out the SIZEOF_LONG etc, right? If not, it's a bug in configure, not something we should patch in the resulting config.h, right?

You can easily discover using "svn log" and "svn blame" that this file was added in r42762 to resolve #17088, when libsndfile was at version 1.0.17. I cannot tell you whether it is still needed today at version 1.0.26 but you could certainly test and find out whether the problem described in #17088 returns if you remove it. If it does, then you should not remove the patch. If this ed script fixes the problem, I'm not concerned about whether there are other ways that the problem could have been fixed. Using ed scripts to fix this type of problem has precedent in MacPorts; see the glib2 port for example.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #49821 – Description

    initial v2  
    1 Here is a patch to the Portfile of audio/libsndfile
     1Here is a patch to the `Portfile` of audio/libsndfile
    22which brings it to the latest 1.0.26 release,
    3 and the upgraded version of files/
     3and the upgraded version of `files/`
    44
    5 The speex.patch removes SPEEX_* from EXTERNAL_* in configure;
    6 I believe speex.patch is a better name, and configure.patch
     5The `speex.patch` removes `SPEEX_*` from `EXTERNAL_*` in `configure`;
     6I believe `speex.patch` is a better name, and `configure.patch`
    77should be replaced with this.
    88
    9 The carbon.patch is a better version of fix-include.patch
    10 which it should replace. Not only does it remove the Carbon.h include
    11 from sndfile-play.c, but it removes Carbon altogether.
     9The `carbon.patch` is a better version of `fix-include.patch`
     10which it should replace. Not only does it remove the `Carbon.h` include
     11from `sndfile-play.c`, but it removes Carbon altogether.
    1212
    13 I am leaving src__config.h.ed as is, but I am not completely sure
    14 about its purpose; if __BIG_ENDIAN__, __LP64__, etc, is defined,
    15 then ./configure (which creates config.h) is supposed to figure out
    16 the SIZEOF_LONG etc, right? If not, it's a bug in configure,
    17 not something we should patch in the resulting config.h, right?
     13I am leaving `src__config.h.ed` as is, but I am not completely sure
     14about its purpose; if `__BIG_ENDIAN__`, `__LP64__`, etc, is defined,
     15then `./configure` (which creates `config.h`) is supposed to figure out
     16the `SIZEOF_LONG` etc, right? If not, it's a bug in `configure`,
     17not something we should patch in the resulting `config.h`, right?
    1818
    1919I also removed the sqlite variant from the Portfile.