Opened 9 years ago

Closed 9 years ago

#49845 closed defect (fixed)

youtube-dl fails to build in trace mode because python is only a runtime, not a build-time dependency

Reported by: neverpanic (Clemens Lang) Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version: 2.3.99
Keywords: Cc:
Port: youtube-dl

Description

youtube-dl uses Python during its build, but only declares a build-time dependency. This makes the build fail in trace mode, because runtime dependencies are not expected to be used during the build and thus hidden. The error is:

:info:build make: Entering directory `/opt/local/var/macports/build/_opt_dports_net_youtube-dl/youtube-dl/work/youtube-dl'
:info:build zip -q youtube-dl youtube_dl/*.py youtube_dl/*/*.py
:info:build /opt/local/bin/python2.7 devscripts/make_contributing.py README.md CONTRIBUTING.md
:info:build make: /opt/local/bin/python2.7: No such file or directory
:info:build /opt/local/bin/python2.7 devscripts/make_supportedsites.py docs/supportedsites.md
:info:build make: /opt/local/bin/python2.7: No such file or directory
:info:build make: *** [CONTRIBUTING.md] Error 1
:info:build make: *** Waiting for unfinished jobs....
:info:build make: *** [supportedsites] Error 1

and later on:

:warn:build The following existing file was hidden from the build system by trace mode:
:msg:build   /opt/local/bin/python2.7

Here's a patch:

  • Portfile

     
    6464default_variants    +ffmpeg
    6565
    6666variant python27 conflicts python34 python35 description {Use Python 2.7} {
    67     depends_run-append  port:python27
    68     configure.python    ${prefix}/bin/python2.7
     67    depends_run-append      port:python27
     68    depends_build-append    port:python27
     69    configure.python        ${prefix}/bin/python2.7
    6970}
    7071
    7172variant python33 requires python34 description {Legacy compatibility variant} {}
    7273
    7374variant python34 conflicts python27 python35 description {Use Python 3.4} {
    74     depends_run-append  port:python34
    75     configure.python    ${prefix}/bin/python3.4
     75    depends_run-append      port:python34
     76    depends_build-append    port:python34
     77    configure.python        ${prefix}/bin/python3.4
    7678}
    7779
    7880variant python35 conflicts python27 python34 description {Use Python 3.5} {
    79     depends_run-append  port:python35
    80     configure.python    ${prefix}/bin/python3.5
     81    depends_run-append      port:python35
     82    depends_build-append    port:python35
     83    configure.python        ${prefix}/bin/python3.5
    8184}
    8285
    8386if {![variant_isset python27] && ![variant_isset python34] && ![variant_isset python35]} {

Change History (1)

comment:1 Changed 9 years ago by neverpanic (Clemens Lang)

Resolution: fixed
Status: newclosed

Committed in r143292, maintainer timeout.

Note: See TracTickets for help on using tickets.