MacVim @7.4.snapshot85: build fails on OS X 10.7 Lion

[persramd@…]

Hi. I recently am having trouble upgrading macvim (as part of a upgrade outdated). After a selfupdate and clean macvim, I get the following message shown below. I've attached the logfile.

The following build commands failed:
	CompileC build/MacVim.build/Release/MacVim.build/Objects-normal/i386/MMCoreTextView.o MMCoreTextView.m normal i386 objective-c com.apple.compilers.llvm.clang.1_0.compiler

[mf2k (Frank Schima)]

In the future, please Cc the port maintainers (port info --maintainers macvim), if any.

[raimue (Rainer Müller)]

:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_editors_MacVim/MacVim/work/macvim-snapshot-85/src/MacVim/MMCoreTextView.m:1129:38: error: use of undeclared identifier 'kCTFontOrientationDefault'; did you mean 'kCTFontOptionsDefault'?
1156	:info:build     CTFontGetAdvancesForGlyphs(font, kCTFontOrientationDefault, refGlyphs,
1157	:info:build                                      ^~~~~~~~~~~~~~~~~~~~~~~~~
1158	:info:build                                      kCTFontOptionsDefault
1159	:info:build /System/Library/Frameworks/ApplicationServices.framework/Frameworks/CoreText.framework/Headers/CTFont.h:203:5: note: 'kCTFontOptionsDefault' declared here
1160	:info:build     kCTFontOptionsDefault               = 0,
1161	:info:build     ^
1162	:info:build 1 error generated.

This API was ​introduced with OS X 10.8 Mountain Lion, so it is not yet available on OS X 10.7 Lion. Since this is an upstream bug, I would kindly ask you to take this ​upstream, as I do not have access to OS X 10.7 to test any possible fixes.

If no solution can be worked out with upstream, I could only raise the required version of OS X to >= 10.8 in the Portfile, which currently still claims >= 10.6.

[raimue (Rainer Müller)]

FYI, upstream is ​about to remove support for OS X <= 10.6. With the next snapshot I will probably have to raise the compatibility to a newer OS X release anyway.

[raimue (Rainer Müller)]

Update to snapshot 90 committed in r144688. This should restore compatibility for OS X 10.7.

[raimue (Rainer Müller)]

Reopened due to #50405. Apparently, this was not fixed in snapshot 90.

[skymoo (Adam Mercer)]

Cc Me!

[persramd@…]

Are there any compiler options that will allow compilation, like disabling "MMCoreTextView"?

[raimue (Rainer Müller)]

You probably only need to adjust the conditional logic at the top of MMCoreTextView.m, as this was introduced with OS X 10.8, not 10.7:

#if MAC_OS_X_VERSION_MIN_REQUIRED < MAC_OS_X_VERSION_10_7

#define kCTFontOrientationDefault kCTFontDefaultOrientation`

However, I have no system to test and no particular interest in old versions of OS X. If you want to fix it, please take it ​upstream.

[raimue (Rainer Müller)]

Right now, MacVim only supports OS X >= 10.8, so I am closing this old issue.