pfft: Build without --disable-shared

[michael-lists@…]

The pfft port builds just fine without the --disable-shared configure flag. The patch below removes it, which is useful for anyone who wants to use PFFT as a dynamic library. Because PFFT does not link to FFTW3 by itself, FFTW3 needs to be explicitly added to the LDFLAGS.

--- ports/math/pfft/Portfile	2015-10-21 17:30:57.000000000 +0200
+++ ports/math/pfft/Portfile	2016-01-14 15:46:15.000000000 +0100
@@ -44,7 +44,7 @@
     }
 
     configure.args-append  MPICC=${mpi.cc} MPIFC=${mpi.f90} \
-        CPPFLAGS=-I${prefix}/include LDFLAGS=-L${prefix} --disable-shared
+        CPPFLAGS=-I${prefix}/include LDFLAGS="-L${prefix} -lfftw3 -lfftw3_mpi"
 }
 
 livecheck.type  regex

[dstrubbe (David Strubbe)]

What do you mean by this? "Because PFFT does not link to FFTW3 by itself, FFTW3 needs to be explicitly added to the LDFLAGS." What sort of actual or potential problem is there in the current situation?

[michael-lists@…]

If you don't add -lfftw3 -lfftw3_mpi, then you get unresolved FFTW3 symbols when libpfft.dylib is made.

[seanfarley (Sean Farley)]

Yes, we should be using shared libraries when possible. Look at my work for SuperLU, MUMPS, and SuiteSparse for example.

[dstrubbe (David Strubbe)]

Thanks for the patch. Committed in r144662.