vte @0.43.2_0: build failure due to libstdc++ compatibility issue on 10.8 and earlier

[dbevans (David B. Evans)]

Build fails as follows on 10.8 and earlier where libstdc++ is the default.

Build excerpt from SL buildbot:

libtool: compile:  /opt/local/bin/clang++-mp-3.4 -DHAVE_CONFIG_H -I. -I.. -DG_LOG_DOMAIN=\"Vte\" -DVTE_API_VERSION=\"2.91\" -DDATADIR=\"/opt/local/share\" -DLIBEXECDIR=\"/opt/local/libexec\" -DLOCALEDIR=\"/opt/local/share/locale\" -DGLIB_DISABLE_DEPRECATION_WARNINGS -DVTE_COMPILATION -I./vte -I./vte -I/opt/local/include -D_REENTRANT -I/opt/local/include/gtk-3.0 -I/opt/local/include/at-spi2-atk/2.0 -I/opt/local/include/at-spi-2.0 -I/opt/local/include/dbus-1.0 -I/opt/local/lib/dbus-1.0/include -I/opt/local/include/gtk-3.0 -I/opt/local/include -I/opt/local/include/cairo -I/opt/local/include -I/opt/local/include/pango-1.0 -I/opt/local/include/harfbuzz -I/opt/local/include -I/opt/local/include/pango-1.0 -I/opt/local/include/atk-1.0 -I/opt/local/include/cairo -I/opt/local/include/pixman-1 -I/opt/local/include -I/opt/local/include/freetype2 -I/opt/local/include -I/opt/local/include/freetype2 -I/opt/local/include/libpng16 -I/opt/local/include -I/opt/local/include/gdk-pixbuf-2.0 -I/opt/local/include/libpng16 -I/opt/local/include/gio-unix-2.0/ -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include -I/opt/local/include -I/opt/local/include/p11-kit-1 -I/opt/local/include -pipe -Os -arch x86_64 -stdlib=libstdc++ -std=gnu++11 -pipe -Wall -Wcast-align -Wendif-labels -Werror=declaration-after-statement -Werror=format=2 -Werror=format-nonliteral -Werror=format-security -Werror=implicit-function-declaration -Werror=init-self -Werror=missing-include-dirs -Werror=missing-prototypes -Werror=pointer-arith -Wextra -Wfloat-equal -Wmissing-declarations -Wmissing-include-dirs -Wmissing-format-attribute -Wmissing-noreturn -Wno-missing-field-initializers -Wno-switch-enum -Wno-unused-parameter -Wno-packed -Wshadow -Wsign-compare -Wstrict-aliasing=2 -Wundef -Wuninitialized -Wwrite-strings -fno-common -fdiagnostics-show-option -fno-strict-aliasing -fstack-protector -Wno-deprecated-declarations -fno-rtti -fno-exceptions -fvisibility=hidden -fvisibility-inlines-hidden -pipe -Os -arch x86_64 -stdlib=libstdc++ -MT libvte_2_91_la-vtestream.lo -MD -MP -MF .deps/libvte_2_91_la-vtestream.Tpo -c vtestream.cc -o libvte_2_91_la-vtestream.o >/dev/null 2>&1
mv -f .deps/libvte_2_91_la-vtetree.Tpo .deps/libvte_2_91_la-vtetree.Plo
/bin/sh ../libtool  --tag=CXX   --mode=compile /opt/local/bin/clang++-mp-3.4 -DHAVE_CONFIG_H -I. -I..  -DG_LOG_DOMAIN=\"Vte\" -DVTE_API_VERSION=\"2.91\" -DDATADIR='"/opt/local/share"' -DLIBEXECDIR='"/opt/local/libexec"' -DLOCALEDIR='"/opt/local/share/locale"' -DGLIB_DISABLE_DEPRECATION_WARNINGS -DVTE_COMPILATION -I./vte -I./vte  -I/opt/local/include -D_REENTRANT -I/opt/local/include/gtk-3.0 -I/opt/local/include/at-spi2-atk/2.0 -I/opt/local/include/at-spi-2.0 -I/opt/local/include/dbus-1.0 -I/opt/local/lib/dbus-1.0/include -I/opt/local/include/gtk-3.0 -I/opt/local/include -I/opt/local/include/cairo -I/opt/local/include -I/opt/local/include/pango-1.0 -I/opt/local/include/harfbuzz -I/opt/local/include -I/opt/local/include/pango-1.0 -I/opt/local/include/atk-1.0 -I/opt/local/include/cairo -I/opt/local/include/pixman-1 -I/opt/local/include -I/opt/local/include/freetype2 -I/opt/local/include -I/opt/local/include/freetype2 -I/opt/local/include/libpng16 -I/opt/local/include -I/opt/local/include/gdk-pixbuf-2.0 -I/opt/local/include/libpng16 -I/opt/local/include/gio-unix-2.0/ -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include -I/opt/local/include -I/opt/local/include/p11-kit-1 -I/opt/local/include  -pipe -Os -arch x86_64 -stdlib=libstdc++ -std=gnu++11 -pipe -Wall -Wcast-align -Wendif-labels -Werror=declaration-after-statement -Werror=format=2 -Werror=format-nonliteral -Werror=format-security -Werror=implicit-function-declaration -Werror=init-self -Werror=missing-include-dirs -Werror=missing-prototypes -Werror=pointer-arith -Wextra -Wfloat-equal -Wmissing-declarations -Wmissing-include-dirs -Wmissing-format-attribute -Wmissing-noreturn -Wno-missing-field-initializers -Wno-switch-enum -Wno-unused-parameter -Wno-packed -Wshadow -Wsign-compare -Wstrict-aliasing=2 -Wundef -Wuninitialized -Wwrite-strings -fno-common -fdiagnostics-show-option -fno-strict-aliasing -fstack-protector -Wno-deprecated-declarations -fno-rtti -fno-exceptions -fvisibility=hidden -fvisibility-inlines-hidden -pipe -Os -arch x86_64 -stdlib=libstdc++ -MT libvte_2_91_la-vteutils.lo -MD -MP -MF .deps/libvte_2_91_la-vteutils.Tpo -c -o libvte_2_91_la-vteutils.lo `test -f 'vteutils.cc' || echo './'`vteutils.cc
vtetypes.cc:24:10: fatal error: 'type_traits' file not found
#include <type_traits>
         ^
1 error generated.
make[3]: *** [libvte_2_91_la-vtetypes.lo] Error 1

Not an issue on 10.9+ where libc++ is the default.

[dbevans (David B. Evans)]

Introduced in ​this commit as part of vte 0.43.1 release.

[dbevans (David B. Evans)]

Reporting this issue upstream for resolution.

Temporary workaround committed in r145277 which restricts the version to 0.43.0 on platforms that use libstdc++. This commit also includes a configuration fix for the +glade variant so revision is incremented. Builds successfully on the 10.8 and 10.6 buildbots.

[dbevans (David B. Evans)]

Considering this fixed for now. Future versions will probably use the cxx11 portgroup,