Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

#50500 closed defect (fixed)

simpler up-to-date qca Port allowing concurrent Qt4 and Qt5 installations

Reported by: RJVB (René Bertin) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.3.4
Keywords: Cc: michaelld (Michael Dickens), macports-dev@…, mkae (Marko Käning)
Port: qca

Description

This is in reaction to https://trac.macports.org/ticket/49109, https://trac.macports.org/ticket/46239 and https://trac.macports.org/changeset/145233 .

I mentioned in the ticket (#46239) that I'd try to combine the new build approach with my own qca version (submitted weeks ago in ticket #49109) but that new build approach seems to hack way too much into things to my taste. That's why I'm marking this as a defect: I don't think ports should change so many things to the default build without very good reason.

I'd like to see a good argumentation

  • why qca should be built as a framework bundle. I strongly doubt most of the dependents in MacPorts expect that. "Just because we can" isn't an argument for making that the default build IMHO, nor is use of the framework in non-MacPorts software. (NB: Marko reported issues rebuilding certain KDE4 ports to me that were apparently resolved after switching to my qca port version.)
  • why the install location of various components has been changed. In particular the plugins: as Qt plugins they should go into Qt's plugin directory; that also resolves any conflicts due to the targeted Qt version
  • why components that used to be part of the main qca port and that have been converted to plugins are provided through new subports. The space gain is minimal, and doesn't justify the cost (additional dependencies for dependent ports) IMHO.

Another issue is that contrary to the update I posted weeks ago, this new qca port provides conflicting Qt4 and Qt5 variants. After all the work that has gone into making those Qt versions co-installable that is a plain regression. One that causes an unnecessary decrease of KDE4 and KF5 co-installability.

I've cleaned up and attached my qca port to this ticket. Normally one would attach diffs, but I feel those are too complex to be very useful here so I'll only attach a diff against the more comparable qca@2.0.3_1 .

Attachments (5)

Portfile (7.1 KB) - added by RJVB (René Bertin) 9 years ago.
patch-src_qac_systemstore_mac.cpp.diff (293 bytes) - added by RJVB (René Bertin) 9 years ago.
patch-qca-ossl.diff (2.6 KB) - added by RJVB (René Bertin) 9 years ago.
patch-qca210-qt550.diff (329 bytes) - added by RJVB (René Bertin) 9 years ago.
qca.diff (10.6 KB) - added by RJVB (René Bertin) 9 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 9 years ago by RJVB (René Bertin)

NB: my version indeed does not currently provide a way to do a framework build; the older 2.0.3 port didn't either.

Changed 9 years ago by RJVB (René Bertin)

Attachment: Portfile added

Changed 9 years ago by RJVB (René Bertin)

Changed 9 years ago by RJVB (René Bertin)

Attachment: patch-qca-ossl.diff added

Changed 9 years ago by RJVB (René Bertin)

Attachment: patch-qca210-qt550.diff added

Changed 9 years ago by RJVB (René Bertin)

Attachment: qca.diff added

comment:2 Changed 8 years ago by mkae (Marko Käning)

Cc: mk@… added

Cc Me!

comment:3 Changed 8 years ago by RJVB (René Bertin)

Resolution: fixed
Status: newclosed

In c802cab4/macports-ports:

port:qca* : proposed adoption and introduction of Qt5 subports

The QCA ports have been without maintainer for a bit now, and lack the
possibility to install for Qt4 and Qt5 concurrently. That possibility is
essential for the future KF5 ports, so I propose that Marko and I adopt
this port and introduce the required changes. The ports as defined by
the current Portfile have seen thorough testing by both of us as well as
by a few "beta testers" of my KF5 ports.
I don't think there is any point in maintaining the Qt4 and Qt5 variants.
The current version also introduces a few changes that are unrelated to
Qt5/KF5 but aim to simplify dependencies by reducing the number of
subports. This is open for discussion w.r.t. the Qt4 versions. I don't
think there is much justification (for use with MacPorts) to build QCA
as a framework, but this could be reintroduced as a variant.

Closes: https://github.com/macports/macports-ports/pull/59
Closes: #50500

comment:4 Changed 8 years ago by RJVB (René Bertin)

In 6d430c18/macports-ports:

port:qca* : proposed adoption and introduction of Qt5 subports

The QCA ports have been without maintainer for a bit now, and lack the
possibility to install for Qt4 and Qt5 concurrently. That possibility is
essential for the future KF5 ports, so I propose that Marko and I adopt
this port and introduce the required changes. The ports as defined by
the current Portfile have seen thorough testing by both of us as well as
by a few "beta testers" of my KF5 ports.
I don't think there is any point in maintaining the Qt4 and Qt5 variants.
The current version also introduces a few changes that are unrelated to
Qt5/KF5 but aim to simplify dependencies by reducing the number of
subports. This is open for discussion w.r.t. the Qt4 versions. I don't
think there is much justification (for use with MacPorts) to build QCA
as a framework, but this could be reintroduced as a variant.

Closes: https://github.com/macports/macports-ports/pull/59
Closes: #50500

Note: See TracTickets for help on using tickets.