Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#50605 closed update (fixed)

py-bob @2.1.0 New release

Reported by: tiagofrepereira2012 (Tiago Freitas Pereira) Owned by: dbevans (David B. Evans)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: andre.anjos@…
Port: py-bob

Description

Hi,

Attached are the set of diff files for the bob@2.1.0 release. Follow bellow a quick description of the updates:

  • New dependency port py-bob-io-audio 2.0.0 (depends of the ticket #50604)
  • py-bob-core was upgraded to the version 2.1.0
  • py-bob-measure was upgraded to the version 2.1.0
  • py-bob-learn-boosting was upgraded to the version 2.0.4 -py- bob-extension upgraded to the version 2.0.11

The remaining diffs have only an increment of the variable revision, so all the dependencies of bob will be rebuilt (as sugested in the ticket #50388)

Thanks to look at it.

Attachments (2)

py-bob.zip (20.7 KB) - added by tiagofrepereira2012 (Tiago Freitas Pereira) 9 years ago.
bob-2.1.0.diff (21.5 KB) - added by dbevans (David B. Evans) 9 years ago.
Patch showing changes committed

Download all attachments as: .zip

Change History (6)

Changed 9 years ago by tiagofrepereira2012 (Tiago Freitas Pereira)

Attachment: py-bob.zip added

comment:1 Changed 9 years ago by dbevans (David B. Evans)

Cc: devans@… removed
Owner: changed from macports-tickets@… to devans@…
Status: newassigned

comment:2 Changed 9 years ago by dbevans (David B. Evans)

Keywords: py-bob removed
Resolution: fixed
Status: assignedclosed
Version: 2.3.4

Committed in r145686 with minor revisions to revision number usage.

Incrementing the revision number of a port indicates that you have made changes to the port that require its rebuild without changing the version number. The revision number sequence starts at 0 (zero), next is 1, etc. When you change the version number, the revision number is then be reset to 0. This is usually indicated by removing the revision declaration from the port. It can then be re-inserted when the revision is incremented to 1, etc.

I made the following changes:

  • where the version was changed, removed the revision declaration to indicate reset to 0.
  • where the version remained constant, incremented the revision by 1 (only).

Patch attached that shows the changes committed relative to the previous versions of the ports.

Thanks for your update (and the new port as well).

Changed 9 years ago by dbevans (David B. Evans)

Attachment: bob-2.1.0.diff added

Patch showing changes committed

comment:3 Changed 9 years ago by dbevans (David B. Evans)

One other suggestion. I just noticed that you are setting the version in each port followed by the github.setup line with the version number inserted again similar to the following

name                         py-bob
version                      2.1.0

...

github.setup                idiap bob 2.1.0 v

This is redundant: github.setup sets version for you from its arguments. You can omit the version line.

I saw this after I committed your changes so I'll leave it to you deal with this in a future submission. The ports work fine as is. You're just setting version twice to the same value.

comment:4 Changed 9 years ago by tiagofrepereira2012 (Tiago Freitas Pereira)

Hi Dave,

Thanks for the commit and the suggestions regarding the port files.

Best Regards

Tiago

Note: See TracTickets for help on using tickets.