Opened 9 years ago
Closed 3 years ago
#50701 closed defect (fixed)
wxWidgets: add patches to support KiCad
Reported by: | mojca (Mojca Miklavec) | Owned by: | mojca (Mojca Miklavec) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | |
Keywords: | Cc: | jyrkiwahlstedt, g5pw (Aljaž Srebrnič) | |
Port: | wxWidgets-3.0, kicad |
Description (last modified by mojca (Mojca Miklavec))
KiCad (#47268) requires some patches of wxWidgets. Here's a list of patches for wxWidgets from the KiCad's build instructions:
in master
- wxwidgets-3.0.0_macosx_scrolledwindow.patch (include; also in 3.0 branch)
- Some scrolling events
- wxwidgets-3.0.2_macosx_magnify_event.patch (include; not in 3.0 branch)
- Adds support for a magnifying mouse gesture (possibly compare the patch with
master
)
- Adds support for a magnifying mouse gesture (possibly compare the patch with
not in master
- wxpython-3.0.0_macosx_multiarch.patch
- Handles arch flags in build scripts, most likely not needed
- wxwidgets-3.0.0_macosx.patch and wxpython-3.0.0_macosx.patch
- iI replaces carbon with cocoa at some places and fixes overlays (I don't completely understand it)
- The patch for wxPython is slightly different from the patch for wxWidgets (why?)
- Is there any ticket on the wxWidgets tracker about this issue?
- wxwidgets-3.0.0_macosx_bug_15908.patch
- Some dirty patch to avoid crashes (I don't understand it, not sure what to do)
- See also http://trac.wxwidgets.org/ticket/15908
- wxwidgets-3.0.0_macosx_soname.patch
- It avoids running
change-install-names
- Similar patch was already in MacPorts in the past; see also http://trac.wxwidgets.org/ticket/15452
- Most likely this is some weird practice of wxWidgets build system, but wxWidgets should work fine for us either with the patch or without
- It avoids running
- wxwidgets-3.0.2_macosx_data_view_ctrl.patch
- I don't understand it
- wxwidgets-3.0.2_macosx_retina_opengl.patch
- Conflicting informations are circulating around about support of retina displays, so I'm a bit confused about why this is needed
- See also https://forums.wxwidgets.org/viewtopic.php?t=36684
- See also https://wiki.wxwidgets.org/WxMac-specific_topics#Retina_display_support
- wxwidgets-3.0.2_macosx_yosemite.patch
- Why exactly is this needed and not included upstream?
- Should the patch only be applied to Yosemite (and El Capitan) or to all versions?
And here's an alternative link with patches and build scripts.
Change History (8)
comment:1 Changed 9 years ago by mojca (Mojca Miklavec)
Description: | modified (diff) |
---|
comment:2 Changed 9 years ago by mojca (Mojca Miklavec)
Description: | modified (diff) |
---|
comment:3 Changed 9 years ago by mojca (Mojca Miklavec)
Description: | modified (diff) |
---|
comment:4 Changed 9 years ago by mojca (Mojca Miklavec)
comment:5 Changed 9 years ago by g5pw (Aljaž Srebrnič)
I spoke to xzcvczx on #kicad, who said:
the yosemite one is needed on elcap and yosemite due to apple changing the webkit include but pre yosemite you can't change it obviously
data_view is not used can probably be scrapped
comment:6 Changed 9 years ago by mojca (Mojca Miklavec)
Can you ask why the yosemite patch hasn't been fixed upstream? It should obviously contain an "if OS X >= 10.10", but it's a trivial one to apply.
comment:8 Changed 3 years ago by ra1nb0w
Resolution: | → fixed |
---|---|
Status: | new → closed |
Close since now kicad is available on macports.
Note: See
TracTickets for help on using
tickets.
See also #50768. It would make some sense to commit the changes together to avoid having to revbump and rebuild wxWidgets twice, even though digesting these changes might be slightly more complex than dealing with the other ticket.