Opened 8 years ago

Closed 8 years ago

#51437 closed defect (fixed)

Should qscintilla force C++ linkage?

Reported by: MarcusCalhoun-Lopez (Marcus Calhoun-Lopez) Owned by: michaelld (Michael Dickens)
Priority: Normal Milestone:
Component: ports Version: 2.3.4
Keywords: Cc:
Port: qscintilla

Description (last modified by ryandesign (Ryan Carsten Schmidt))

Many of the header files force C++ linkages QScintilla but only on Macs

#ifdef __APPLE__                                                                                                                                                                                           
extern "C++" {                                                                                                                                                                                             
#endif 

This causes a problems when trying to build octave with GCC:

Why forced C++ linkage is needed (but only on Macs) is not clear to me.
I have posted a question on the upstream mailing list, but so far, no response.

I have attached a patch that seems to fix the problem, but it seems a little dangerous without knowing why it was done in the first place.

Attachments (2)

Portfile.diff (706 bytes) - added by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez) 8 years ago.
patch-remove_extern.diff (20.9 KB) - added by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez) 8 years ago.

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)

Attachment: Portfile.diff added

Changed 8 years ago by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)

Attachment: patch-remove_extern.diff added

comment:1 Changed 8 years ago by ryandesign (Ryan Carsten Schmidt)

Description: modified (diff)

comment:2 Changed 8 years ago by MarcusCalhoun-Lopez (Marcus Calhoun-Lopez)

Resolution: fixed
Status: newclosed

Based on the upstream response, this seems like a safe change to make.
Fixed in r149051.

Note: See TracTickets for help on using tickets.